Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-1946] improvement: when changing email after using Google Sign in, show dialog and change ID provider to email + pw #9515

Closed
PeerRich opened this issue Jun 14, 2023 · 5 comments · Fixed by #9611
Assignees
Labels
🧹 Improvements Improvements to existing features. Mostly UX/UI Medium priority Created by Linear-GitHub Sync
Milestone

Comments

@PeerRich
Copy link
Member

PeerRich commented Jun 14, 2023

when i make an account with Google Workspace: "peer@cal.com" and then change this:

it should show a dialog like canva:

and afterwards change my identity provider to "CAL" from "GOOGLE" and delete the ID Token from google.

changing email does still require an email verification

From SyncLinear.com | CAL-1946

@maige-app maige-app bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Jun 14, 2023
@PeerRich PeerRich changed the title improvement: when changing email after using Google Sign in, show dialog and change ID provider to email + pw [CAL-1946] improvement: when changing email after using Google Sign in, show dialog and change ID provider to email + pw Jun 14, 2023
@PeerRich PeerRich added the Medium priority Created by Linear-GitHub Sync label Jun 14, 2023
@PeerRich PeerRich assigned PeerRich and gitstart-calcom and unassigned PeerRich Jun 14, 2023
@gitstart-app
Copy link
Contributor

gitstart-app bot commented Jun 14, 2023

Here is the GitStart Ticket for this issue: https://clients.gitstart.com/calcom/1/tickets/CALCOM-9515

@JaideepGuntupalli
Copy link
Contributor

JaideepGuntupalli commented Jun 15, 2023

Hey i want to work on this.

So, basically when we login with google and change the email to any email, it should change the identity provider and all the other stuff you mentioned? @PeerRich

@PeerRich PeerRich removed their assignment Jun 17, 2023
@PeerRich
Copy link
Member Author

@alannnc it seems like gitstart is working on this already

@PeerRich
Copy link
Member Author

Hey i want to work on this.

So, basically when we login with google and change the email to any email, it should change the identity provider and all the other stuff you mentioned? @PeerRich

hey @JaideepGuntupalli correct.

when going from Google => change email it should change id provider and send a password reset link

@gitstart-calcom
Copy link
Contributor

Hi @PeerRich We didn't push a PR to solve it because already have an open PR here, do you want us to solve this?

@PeerRich PeerRich added this to the v3.3 milestone Aug 4, 2023
@keithwillcode keithwillcode modified the milestones: v3.3, v3.2 Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Improvements Improvements to existing features. Mostly UX/UI Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants