Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not add a webhook to github #27

Closed
abrahamcalsin opened this issue Nov 10, 2022 · 6 comments
Closed

does not add a webhook to github #27

abrahamcalsin opened this issue Nov 10, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@abrahamcalsin
Copy link

It doesn't add a webhook to my github repository when I select my project repo to sync with linear.app, it loads, but when I go back to github I don't see a webhook added.

synclinear.com

image

GitHub settings

image


PS: The first one did add a webhook, but then I deleted it and re-synced my repo, but this time it no longer added a webhook.

@PeerRich PeerRich added the bug Something isn't working label Nov 10, 2022
@tedspare
Copy link
Collaborator

tedspare commented Nov 12, 2022

Thanks for raising this bug @abrahamcalsin

To clarify, when you say "the first one added a webhook", do you mean Linear or GitHub had the webhook?

Also, did you manually delete the GH webhook by chance?

These will help to troubleshoot then push a fix!

@tedspare tedspare self-assigned this Nov 12, 2022
@abrahamcalsin
Copy link
Author

abrahamcalsin commented Nov 13, 2022

Thanks for raising this bug @abrahamcalsin

To clarify, when you say "the first one added a webhook", do you mean Linear or GitHub had the webhook?

Also, did you manually delete the GH webhook by chance?

These will help to troubleshoot then push a fix!

Well, the first time, it added me a webhook in github.
More on linear added me as an Authorized Application just that:
image

Yes, in github the webhook I deleted it manually, and when I try to sync again it doesn't recognize that I deleted it and that's why it doesn't add me a new webhook.

@tedspare
Copy link
Collaborator

Thanks for clarifying, @abrahamcalsin. I'll look into adding a guardrail for manually-deleted webhooks.

In the meantime, to fix your sync, feel free to manually add the webhook back:

  • Endpoint: https://synclinear.com/api
  • Content type: application/json
  • SSL verification: Enable
  • Events: Let me select individual events -> issues, issue comments, labels

Please let me know if that doesn't work!

@abrahamcalsin
Copy link
Author

Thanks for clarifying, @abrahamcalsin. I'll look into adding a guardrail for manually-deleted webhooks.

In the meantime, to fix your sync, feel free to manually add the webhook back:

  • Endpoint: https://synclinear.com/api
  • Content type: application/json
  • SSL verification: Enable
  • Events: Let me select individual events -> issues, issue comments, labels

Please let me know if that doesn't work!

Well I tried to manually add a webhook and I get a 500 error, so it doesn't work.

Could it be that I am missing the secret?

@yang-han
Copy link

I met exactly the same issue here 🙌 Thanks for the authors looking into it

@blockmia
Copy link

blockmia commented Nov 29, 2022

@tedspare
I had the same problem.
Webhooks were added when first synchronizing. They will not be added when manually removed and then synchronized again.
Secret is missing on GitHub if I fill it in manually, so how do you get secret or can you automatically add it again when synchronizing after detecting the deleted webhooks?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants