New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sync matching for multi team setup #34
Conversation
Fixes a problem when same users part of multiple linear teams would always choose first sync
Not sure if there are other parts of the code than need this to be added to address this. But for our particular cases it seems to work well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linear comment events seem to not include their teamId
- what happens in that case?
Otherwise, LGTM
is this safe to merge? |
@tedspare Let me check how it works for comments on linear 🙏 |
@tedspare good catch, i've refactored the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tedspare done 🎉 |
Summary
When filtering sync, add a
linearTeamId
as part of the comparison to allow same user to be part of multiple linear teams. Internally we would love to sync issues from aRoadmap
team to another repository at https://github.com/novuhq/roadmap, currently issues are not synced in this setup (we already sync issues for our main reponovuhq/novu
Reproduce