Refactor webhook handlers #36
Conversation
Fixes a problem when same users part of multiple linear teams would always choose first sync
| export class ApiError extends Error { | ||
| constructor(public message: string, public statusCode: number) { | ||
| super(message); | ||
| } | ||
| } |
There was a problem hiding this comment.
New exception class used by the handlers, so they can throw instead of calling res.status directly.
| import { linearQuery } from "../apollo"; | ||
| import { ApiError } from "../errors"; | ||
|
|
||
| export async function githubWebhookHandler( |
There was a problem hiding this comment.
Contents of this function are the contents of the github if statement previously
There was a problem hiding this comment.
Have you replaced early res.send() calls with returns / throws?
Fix/multi team bug
Refactor pettitio to got
Refactor created issue to got
Update petitio types for got
| }); | ||
| } | ||
| } | ||
| } catch (e) { |
There was a problem hiding this comment.
I like this - really clean
|
Monumental effort @scopsy - this will make the codebase much easier to navigate. Happy to review when ready. |
|
Will wait until we merge the petitio PR, because will have a lot of conflicts here. After some tests we could merge it aswell 🎉 |
Webhooks refactor internal
Fix sync teamId condition
|
@tedspare merged conflicts now 🚀 |
|
@scopsy ready to merge? |
|
Good on my end, we have this deployed internally for the last few days already. |
Summary
Refactored the main POST route contents to use 2 handlers for webhook parsing. The file was really long, and it made testing and maintaining the codebase very hard. This refactor includes:
ifstatement to a new fileutils/webhook/linear.handler.tsifstatement to a new fileutils/webhook/github.handler.tsreqobject inside the handlers (body and headers passed as params)res.sendinside the handlers, the handlers exit in 2 ways:I hope these changes are the first step to further refactor the handler functions as they contain more duplicated code.