Need testing from the community

[louisameline]

Hi, it would be great if people who use Tooltipster could upgrade to the next planned version, which is 2.3.0, and tell us if everything works fine for them.

This next version is sitting on the 'dev' branch of the project. Also, from now on, please make your pull requests based on this branch.

Tooltipster has been refactored and enhanced for v2.3.0 and your help in testing would be appreciated until we can get automated tests up and running.

Hopefully nothing should break after you upgrade, but if it does, please take a look at this page here first #75. If you think you use Tooltipster by the book and still see an issue, please make us a bug report. Thank you.

[alesnav]

Testing it and found one minibug:

jsfiddle: http://jsfiddle.net/kE2Ut/2/

The same code with main branch works fine; but in this case, using the dev branch, throws the following error:

"Uncaught TypeError: Cannot call method 'css' of null"

Anyway, it is shown via javascript console, but nothing happens on the web aparently, i mean, you won't see any error in the web without opening the javascript console. It seems that it tries to change something on css after hide tooltip, instead of before.

Can you please check this?

Thanks!

EDIT: If you click on "Open fancybox", then click on "OK!" without filling any input and finally write something in one of them, you will see the same error: "Uncaught TypeError: Cannot call method 'css' of null"

[alesnav]

One more thing that happens only using the dev branch:

jsfiddle: http://jsfiddle.net/kE2Ut/3/

I've added a new condition to validate the second field: it must be a number.

Steps to reproduce the problem:
1.- Click on Open fancybox
2.- Fill in the second field (edit2) with, for example "a"
3.- Click on the other field. A tooltip will be shown because "a" is not a number, but that tooltip will be placed in the middle of the form, instead of on the right of the field affected.
4.- Now, if you write something in the other field (edit1), leaving the other field filled with "a", and click "OK!", both tooltips are placed in the right position.

So, this bug will appear only if one tooltip is shown.

Thanks!

P.D.: if I change the line "$(element).tooltipster('update', $(error).text());" by "$(element).tooltipster('content', $(error).text());", the bug is also there

P.D.2.: anyway, this tool is awesome! :)

[louisameline]

Hello alesnav, thanks for feedback and support !

So we have 2 issues here : the error thrown and the positioning.

About the error, your validation plugin calls the errorPlacement and success callbacks twice for each input when something is typed, which is already weird. It currently results in showing/hiding/showing/hiding the tooltip and because of Tooltipster's animation timeouts, it messes things up (although it shouldn't if Tooltipser was flawless ;)

I already saw and fixed a bug thanks to you, but we still have some work on our end to manage these timeouts better and solve the issue for good.

But you can also improve things in your own code to work around the issue : when the error message is an empty string, do not call Tooltipster's show method, but rather its hide method (or nothing at all since success() will take care of it). As for your callbacks being called twice, I don't know if you can do something about it as I am not sure if this behavior comes from the validation plugin or from the way you implemented it.

You can see it work here : http://jsfiddle.net/kE2Ut/7/

FYI, you saw no issue in the previous version of Tooltipster because putting an empty string in a Tooltip would hide the tooltip, but now an empty string is considered content strictly speaking (only NULL represents a lack of content now).

Now about the positioning (in Chrome only it seems), it's duly noted, we have other things to rewrite in there anyway when we can.

Thanks

[louisameline]

First issue fixed. I'll open a new issue with the positioning bug to have 1 thread per bug.

[alesnav]

Thanks louisameline,

First issue fixed, confirmed :)

[louisameline]

Version 3.0 is out, feedback is welcome.