Pass additional context to TitleHelper#title #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helper previously passed the view assigns to the PageTitle to be used in internationalised strings. This commit allows the caller to pass a Hash which will be merged into the view assigns, making it possible to use additional values in page titles.
|
@calebthompson Using single quotes seems to be consistent with the surrounding code. Would you prefer that I follow the style of the code, or the recently amended thoughtbot style guide? |
|
That of the surrounding code, please. |
| ```yaml | ||
| en: | ||
| titles: | ||
| application: 'AppName - %{user_name}' |
There was a problem hiding this comment.
For a couple of reasons I am of the opinion that it is better to put an app name after variable content in a page title. Would you mind swapping these?
There was a problem hiding this comment.
Sure thing. Done.
|
Thanks! 2175dd4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helper previously passed the view assigns to the PageTitle to be used in internationalised strings. This PR allows the caller to pass a Hash which will be merged into the view assigns, making it possible to use additional values in page titles.