Fix some type errors #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -226,7 +226,7 @@ void jack_client::calculate_plugin_order(std::vector<int> &indices) | |||
| map<string, int>::const_iterator p = port_to_plugin.find((*k) + cnlen + 1); | |||
| if (p != port_to_plugin.end()) | |||
| { | |||
| run_before.insert(make_pair<int, int>(p->second, i)); | |||
| run_before.insert(make_pair<const int&, unsigned int&>(p->second, i)); | |||
There was a problem hiding this comment.
I think it would be simpler to call the std::pair constructor directly here, like this:
run_before.insert(pair<int, int>(p->second, i));There was a problem hiding this comment.
Or maybe like this (which also seems to work):
run_before.insert(make_pair(p->second, i));There was a problem hiding this comment.
Yup, make_pair(p->second, i) did the job for me too.
The other changes are still necessary though.
|
Thanks for fixing! Are all changes and improvements jcowgill mentioned committed in this request? Then I would simply merge it. |
|
This also affects the Arch Linux AUR package |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some troubles to compile Calf because of some type/casting errors.
Fixed that by forcing the types.
(Was it a good idea ?)