Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rails-saml generator or engine #1

Open
drnic opened this issue Jul 3, 2012 · 1 comment
Open

Create rails-saml generator or engine #1

drnic opened this issue Jul 3, 2012 · 1 comment

Comments

@drnic
Copy link
Contributor

drnic commented Jul 3, 2012

The take away from this example app is all the extra code that is required on top of the ruby-saml project (plus the important SLO code paths).

Is enough of the rails code here the same for all apps (and we make a rails engine) or is it truly a starting point (and we make a rails generator)?

@calh
Copy link
Owner

calh commented Jul 5, 2012

Boy... engine vs generator is a very good question. On my own systems, I moved all of the Accounts stuff into an engine gem, and then use that in a few authentication Rails apps we have. That could probably use some more polishing, but it's functional at least. Plus, it's used only for changing SAML settings, and should be well hidden from the end users.

The SLO controller code might also deserve an engine, since it's a pretty standard part of the SAML flow. The only reason it might need tweaking is if there's an IdP out there that behaves wacky.

The index / consume methods might need to change for a given environment though. I could see people needing to set cookies, or do other redirect actions. But there are probably better Rails methods for providing this functionality to the developer if they were included in an engine. Thoughts on that?

Thanks for taking a look at my project!

--Cal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants