Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add Drift Widget #4

Closed
mirshko opened this issue Dec 2, 2019 · 2 comments · Fixed by #7
Closed

Suggestion: Add Drift Widget #4

mirshko opened this issue Dec 2, 2019 · 2 comments · Fixed by #7

Comments

@mirshko
Copy link
Contributor

mirshko commented Dec 2, 2019

I'm sure its already in the pipeline for this package, but adding Drift messenger support would be awesome as well!

Screen Shot 2019-12-02 at 12 21 50

@mikedijkstra
Copy link
Contributor

Hey @mirshko, thanks for logging this.

We’re not using Drift and have no reason to add it to the library ourselves. Do you think this is something you’d be interested in contributing to the library?

We've added details for Adding a provider to the README and we’d be happy to coach you through the PR process.

@mirshko
Copy link
Contributor Author

mirshko commented Dec 3, 2019

For sure!

It looks like the Drift widget has a line that send the version of the Drift snippet to the widget for analytics, I presume this is something we should just keep an eye on should the production Drift snippet change?

I'm fairly sure this is needed or at least common practice, I could reach out to a Drift engineer for some advice on this as well as needed.

PR Incoming.

Screen Shot 2019-12-03 at 09 54 02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants