Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZMQ::FFI uses a fixed size (40) memptr for zmq_msg_t #9

Closed
parth-j-gandhi opened this issue Sep 10, 2014 · 3 comments
Closed

ZMQ::FFI uses a fixed size (40) memptr for zmq_msg_t #9

parth-j-gandhi opened this issue Sep 10, 2014 · 3 comments

Comments

@parth-j-gandhi
Copy link

The tests for this module core dump against the latest development version of libzmq.
Please look into it.

@calid
Copy link
Member

calid commented Sep 10, 2014

It looks like the size of the zmq_msg_t struct recently changed in the dev repo. I'll look into a way of generating this value instead of hard coding it.

calid added a commit that referenced this issue Sep 11, 2014
regenerate constants module with new constant

this addresses GH #9
calid added a commit that referenced this issue Sep 11, 2014
regenerate constants module with new constant

this addresses GH #9
@calid
Copy link
Member

calid commented Sep 11, 2014

ok this should be resolved on master, so let me know if you still experience problems. I now generate zmq_msg_t size by using the headers of all the zeromq versions including dev. I use 2x the largest size among all versions, which should provide sufficient wiggle room between ZMQ::FFI releases and regenerations of the size constant.

I've added tests against the libzmq dev version in addition to stable, and have requested daily travis builds at https://traviscron.pythonanywhere.com. So any future explosions caused by changes in libzmq dev should be noticed immediately.

Thanks for the report!

@calid calid closed this as completed Sep 11, 2014
@parth-j-gandhi
Copy link
Author

Thanks for the quick turnaround! Works like a charm..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants