Return insert_count on .save() #67

denhartog · 2018-01-23T05:29:34Z

No description provided.

Return insert_count on .save()

coveralls · 2018-01-23T05:33:18Z

Coverage increased (+0.5%) to 98.039% when pulling 68992e2 on denhartog:master into 8e9e46e on california-civic-data-coalition:master.

denhartog · 2018-01-23T05:37:29Z

Travis error is:
3.5 is not installed; attempting download
Downloading archive: https://s3.amazonaws.com/travis-python-archives/binaries/ubuntu/14.04/x86_64/python-3.5.tar.bz2
curl: (7) Failed to connect to s3.amazonaws.com port 443: Connection timed out
The command "curl -s -o python-3.5.tar.bz2 ${archive_url}" failed and exited with 7 during .
Your build has been stopped.

palewire · 2018-01-23T18:06:52Z

I'm alright with this change, I think. Though should we be trying to mirror the dictionary now returned by some Django insert and delete commands? Or am I overthinking it?

denhartog · 2018-01-23T18:27:42Z

Seems unnecessary; you mean something like .delete():
(4, {'weblog.Entry': 2, 'weblog.Entry_authors': 2})
E.G.
return (insert_count, {'app.Model': insert_count})

palewire · 2018-01-23T18:32:23Z

Alright. We can skip it. One thing I would like yet is a unittest that would verify the number is being returned and is accurate.

Compress setup_query() selection clause

palewire · 2018-02-03T20:16:29Z

postgres_copy/copy_to.py

@@ -24,10 +24,11 @@ def setup_query(self):
            for field in self.query.copy_to_fields:
                # raises error if field is not available
                expression = self.query.resolve_ref(field)
-                if field in self.query.annotations:


This change seems like a good one, but unrelated to insert_count. Is that right, or am I missing something?

palewire · 2018-02-03T20:16:55Z

postgres_copy/copy_from.py

@@ -101,6 +101,8 @@ def save(self, silent=False, stream=sys.stdout):
                "%s records loaded\n" % intcomma(insert_count)
            )

+        return insert_count


I'd like a unit test yet that verifies this number is returned, and that it is accurate.

palewire · 2018-02-03T22:25:04Z

I've made some changes and merged.

denhartog added 2 commits January 11, 2018 18:52

Return insert_count on .save()

b27e2dc

Merge pull request #1 from denhartog/return-insert_count-on-save

30a41fa

Return insert_count on .save()

denhartog requested review from gordonje and palewire as code owners January 23, 2018 05:29

denhartog added 2 commits January 23, 2018 10:34

Compress setup_query() selection clause

9f425c5

Merge pull request #2 from denhartog/denhartog-compress-setup_query

68992e2

Compress setup_query() selection clause

palewire requested changes Feb 3, 2018

View reviewed changes

palewire merged commit 68992e2 into palewire:master Feb 3, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Return insert_count on .save() #67

Return insert_count on .save() #67

denhartog commented Jan 23, 2018

coveralls commented Jan 23, 2018 •

edited

denhartog commented Jan 23, 2018

palewire commented Jan 23, 2018

denhartog commented Jan 23, 2018

palewire commented Jan 23, 2018

palewire Feb 3, 2018

palewire Feb 3, 2018

palewire commented Feb 3, 2018 •

edited

Return insert_count on .save() #67

Return insert_count on .save() #67

Conversation

denhartog commented Jan 23, 2018

coveralls commented Jan 23, 2018 • edited

denhartog commented Jan 23, 2018

palewire commented Jan 23, 2018

denhartog commented Jan 23, 2018

palewire commented Jan 23, 2018

palewire Feb 3, 2018

Choose a reason for hiding this comment

palewire Feb 3, 2018

Choose a reason for hiding this comment

palewire commented Feb 3, 2018 • edited

coveralls commented Jan 23, 2018 •

edited

palewire commented Feb 3, 2018 •

edited