Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift+Click lost its functionality on the Smart Reply button #36

Open
sphh opened this issue Sep 25, 2022 · 10 comments
Open

Shift+Click lost its functionality on the Smart Reply button #36

sphh opened this issue Sep 25, 2022 · 10 comments
Assignees

Comments

@sphh
Copy link

sphh commented Sep 25, 2022

In plain Thunderbird it is possible to switch the reply format by holding the SHIFT key, when clicking on the Smart Reply button: If the standard reply format is Plain text, holding the SHIFT key would switch to html format.

With ChangeQuote installed, this functionality is lost. Now I would have to click on the down-arrow to select the format. Would it be possible to retain the original behaviour?

I would also prefer a configuration option to remove the down-arrow on the Smart Reply button, but that is just a minor issue …

Thunderbird 91.11.0 (64-bit) on Linux Mint 20.3

@caligraf caligraf self-assigned this Oct 24, 2023
@caligraf
Copy link
Owner

I have just released a new version compatible with Thunderbird 115.
https://github.com/caligraf/ChangeQuote/releases/download/1.7.6/ChangeQuote.xpi
The behavior of SHIFT key should be the same with and without ChangeQuote installed.
Could you retest with the version 1.7.6 ?

@sphh
Copy link
Author

sphh commented Oct 24, 2023

Many thanks for the update. I installed version 1.7.6 in Betterbird 115.3.2. In ChangeQuote's settings I ticked Use in reply the same format (html or text) of the original mail and Default. When I click on the Smart Reply button the reply is always in plain text, regardless of the format of the message I reply to. If I Shift-click on the Smart Reply button I always get the reply in HTML format.

What I meant in my original post is, that I would love that a simple click always opens the message in the format of the original message. A Shift-click would always open the reply in the other format. Is that possible? What settings would I need?

@sphh
Copy link
Author

sphh commented Oct 24, 2023

Same with Thunderbird 115.3.1 (64-bit) – both on Linux Mint 21.2 Cinnamon.

@caligraf
Copy link
Owner

if you tick Use in reply the same format (html or text) of the original mail and Default. the email will be sent in the same format as the original email. But I confirm there is a bug when I reply in the compose window it is in plain text even if the original email is in HTML, I will fix it.
And if you ticked the setting Compose messages in HTML format in Composition & Addressing part of your Account settings the email will in HTML in the compose window even if you reply to an email in plain text. So you need to untick Compose messages in HTML format

@sphh
Copy link
Author

sphh commented Oct 25, 2023

I never had the Compost messages in HTML format ticked in account settings, but it might be worth to add a note to the ChangeQuote settings to avoid confusion.

Thanks for looking into this!

@caligraf
Copy link
Owner

Could you check the type of the format in source of the emails you try to reply with the same format ?

The source of the email can be displayed by clicking on More button and choose View source.
In the source the types of format are the lines Content-Type.
I would like to know if the problem happens for a particular type ( multipart/alternative, text/plain, text/html, multipart/mixed, ... )

@sphh
Copy link
Author

sphh commented Oct 25, 2023

I now tried it on the following emails (all Content-Types in the main header):

  • Content-Type: multipart/related
  • Content-Type: multipart/alternative
  • Content-Type: text/plain
    Both open the mail in plain text with a click and in HTML format with a Shift-Click.

@caligraf
Copy link
Owner

f you tick Use in reply the same format (html or text) of the original mail and Defaultyou have below behavior:

  • Content-Type: multipart/related : the reply email will be in plain text if the related content is in plain text , there should be another Content-type in the source of the email : it can be plain text, html or alternative
  • Content-Type: multipart/alternative: the reply email will be in plain text if Compose messages in HTML is untick otherwise it will be in html
  • Content-Type: text/plain: the reply email will be in plain text

To summarize Default will use the value of Compose messages in HTML in account settings: untick equals reply in plain text and tick equals reply in HTML

I will do a fix to handle the case of multipart/related, currently it is not handled correctly.

@sphh
Copy link
Author

sphh commented Oct 25, 2023

Thanks for your explanation.

If I understand you correctly: If I want the following behaviour:

  • If the message display is HTML-formatted, the reply should be in HTML format.
  • If the message display is plain text, the reply should be in plain text.
    I have to tick Use in reply the same format (html or text) of the original mail, Default and Compose messages in HTML (from the account settings).

I set this settings as described, but still it does not work as described. I am genuinely confused.

@caligraf
Copy link
Owner

It seems the account settings Compose messages in HTML overrides the ChangeQuote settings. I need to check with Thunderbird team why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants