Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

115 compatibility plan? #39

Open
gessel opened this issue Oct 5, 2023 · 39 comments
Open

115 compatibility plan? #39

gessel opened this issue Oct 5, 2023 · 39 comments
Assignees

Comments

@gessel
Copy link

gessel commented Oct 5, 2023

115 once again demonstrates TB devs disregard of the developer community and breaks plugins essential to efficient use of the product. I realize this is an endless battle against a truly uncaring project that believes only they know the one true way to do email, but is there any hope of a fix?

@arcanetrivia
Copy link

I found it funny that ChangeQuote at last had an update on October 2 (although I didn't come see what it was about, also I'm a bit confused that 1.6.1, as Thunderbird reports, isn't mentioned as the latest release here on Github - it says 1.6?)... and then just a day or so later, TB 115 immediately broke it! Probably just a versioning conflict, but yeah Mozilla's model of how it handles addons now (vs. the days when you could fool it by messing about in about:config) is sometimes really disruptive and probably burdensome to developers...

@gessel
Copy link
Author

gessel commented Oct 5, 2023

Agree the update seems to have been almost synchronous. Hopefully it won't be a horrible painful fix due to some capriciously deleted API hook. 115 is feeling like another 78 where the devs decide they know how email is supposed to work and anyone figuring out ways to make it different is not just wrong, but so immorally wrong that they need to be stopped for their own benefit.

Each one of these API hook flushes convinces pro-bono devs of really critical plugins that make TB usable for most people at all that it isn't worth it, that they're not appreciated. Mozilla's outreach to the ecosystem is, to say the least, lacking. That no dev, no product manager ever addresses the legitimate horror show of their "upgrades" speaks volumes.

But so too does the fact that there's no real alternative. Commercial software is, if anything, even less responsive. And the pressure of "give us all your datas for free email" web services has made useful, privacy preserving, "own your data," email clients a niche product. So, in the end, we'll figure out how to undo and work around the UI/UX/API horrors visited upon us by the uncaring devs in time, as we have many times before. Just frustrating to have to do it again. You'd think they'd have learned from 78, but no....

@Enkidu70
Copy link

I use CQ 1.6.1 but my TB 115.3.1 (LinuxMint) tells me, CQ is not compatible with it!?

Is there a way to enable it again?

Tnx in advance.

@caligraf caligraf self-assigned this Oct 12, 2023
@caligraf
Copy link
Owner

I'm working on it, but it takes times because I need to rewrite code due to API changes.

@gessel
Copy link
Author

gessel commented Oct 12, 2023

I'ma gonna guess there was no active outreach from Mozilla to give a critical developer, such as yourself, any input in these API changes or even giving sufficient advance notice and guidance to proactively accommodate them?

@caligraf
Copy link
Owner

The issue is that I didn't expect such impact

@caligraf
Copy link
Owner

I have almost done all of the work, a pre-release version 17.0 is available here:
https://github.com/caligraf/ChangeQuote/releases/download/1.7.0/ChangeQuote.xpi
I just need to finish localization: only English and French are available for the moment.

@arcanetrivia
Copy link

We're all annoyed at Mozilla here really, not at you! :)

@BillH99999
Copy link

BillH99999 commented Oct 22, 2023

Thanks for the update caligraf! 1.7.0 seems to be working great for me except for an extra [[br /]] being put at the end.

Is this a bug in 1.7.0 or do I need to change a setting somewhere?

image

Bll

@gessel
Copy link
Author

gessel commented Oct 22, 2023

Indeed, it is Mozilla, not you. We've been through this over and over and it feels almost as if they break API calls not merely capriciously but maliciously. Thank you for your awesome work maintaining truly essential features for a core productivity tool.

@caligraf
Copy link
Owner

Thanks for the update caligraf! 1.7.0 seems to be working great for me except for an extra [[br /]] being put at the end.

Is this a bug in 1.7.0 or do I need to change a setting somewhere?

image

Bll

It might be a setting to change in preferences of the extensions ChangeQuote (screenshot below) , what settings have you configured ?
image

@Duncan-Moore
Copy link

Thanks for the 1.7.0 update.
I'm using the "Close message window after reply or forward" option.
Unfortunately, the message window remains open after both replying and forwarding.

@caligraf
Copy link
Owner

The case of forward was not handled, I updated the code to close the window when the option is checked
Here is a new pre-release version :
https://github.com/caligraf/ChangeQuote/releases/download/1.7.1/ChangeQuote.xpi

But I confirm there is a bug in the case of reply when standard header option is also checked: the window is not closed.
I will fix it.

@caligraf
Copy link
Owner

Finally I found the bug for the case when option "Close message window after reply or forward " is checked and when "standard Thunderbird reply header" is selected
Here is a new pre-release version 1.7.2 where the bug is fixed:
https://github.com/caligraf/ChangeQuote/releases/download/1.7.2/ChangeQuote.xpi

@BillH99999
Copy link

Thanks for the update caligraf! 1.7.0 seems to be working great for me except for an extra [[br /]] being put at the end.
Is this a bug in 1.7.0 or do I need to change a setting somewhere?
image
Bll

It might be a setting to change in preferences of the extensions ChangeQuote (screenshot below) , what settings have you configured ?

Here are my settings. These are the same as I was using in Thunderbird 102 with the version of ChangeQuote that worked with TB 102 (I can't remember which one).

image

@Duncan-Moore
Copy link

Thanks for the very quick updates. I use the standard header option.
1.7.2 is closing the window with forward, but it's still not doing it with reply.

@caligraf
Copy link
Owner

Thanks for the update caligraf! 1.7.0 seems to be working great for me except for an extra [[br /]] being put at the end.
Is this a bug in 1.7.0 or do I need to change a setting somewhere?
image
Could you try the new version 17.7.3 I did:
https://github.com/caligraf/ChangeQuote/releases/download/1.7.3/ChangeQuote.xpi
I fixed linebreak option
Bll

It might be a setting to change in preferences of the extensions ChangeQuote (screenshot below) , what settings have you configured ?

Here are my settings. These are the same as I was using in Thunderbird 102 with the version of ChangeQuote that worked with TB 102 (I can't remember which one).

image

@BillH99999
Copy link

Thanks for the update caligraf! 1.7.0 seems to be working great for me except for an extra [[br /]] being put at the end.
Is this a bug in 1.7.0 or do I need to change a setting somewhere?
image
Could you try the new version 17.7.3 I did:
https://github.com/caligraf/ChangeQuote/releases/download/1.7.3/ChangeQuote.xpi
I fixed linebreak option

@caligraf

That's working great now. Thanks.

On a slightly different topic, why are these two options grayed out?

"Add a linebreak in text plain headers"
"Html tags supported"

Thanks,
Bill

@caligraf
Copy link
Owner

Thanks for the update caligraf! 1.7.0 seems to be working great for me except for an extra [[br /]] being put at the end.
Is this a bug in 1.7.0 or do I need to change a setting somewhere?
image
Could you try the new version 17.7.3 I did:
https://github.com/caligraf/ChangeQuote/releases/download/1.7.3/ChangeQuote.xpi
I fixed linebreak option

@caligraf

That's working great now. Thanks.

On a slightly different topic, why are these two options grayed out?

"Add a linebreak in text plain headers" "Html tags supported"

Thanks, Bill

I think there is a bug when initializing the options values, the two options should be available, I will fix it.
A workaround to change the two options : If you change your choice from "customized header reply" to "Standard Thunderbird reply header" and next choose again "customized header reply" , the two options are available.

@caligraf
Copy link
Owner

Thanks for the very quick updates. I use the standard header option. 1.7.2 is closing the window with forward, but it's still not doing it with reply.

It might be a problem link to the identification of the window to close. In the case of the reply, is the window title name is "subject - Mozilla Thunderbird" where subject is the subject of the e-mail you reply to ?

@Duncan-Moore
Copy link

Thanks for the very quick updates. I use the standard header option. 1.7.2 is closing the window with forward, but it's still not doing it with reply.

It might be a problem link to the identification of the window to close. In the case of the reply, is the window title name is "subject - Mozilla Thunderbird" where subject is the subject of the e-mail you reply to ?

The window title name of the email I want to forward/reply to is:
"subject - Mozilla Thunderbird"

If I click forward, the new window title name becomes:
"Write: Fwd: subject - Thunderbird"

If I click reply, the new window title name becomes:
"Write: Re: subject - Thunderbird"

@caligraf
Copy link
Owner

I changed the way I search the window to close in a new version 1.7.5:
https://github.com/caligraf/ChangeQuote/releases/download/1.7.5/ChangeQuote.xpi
@Duncan-Moore Could you test it ?

@BillH99999
Copy link

On a slightly different topic, why are these two options grayed out?
"Add a linebreak in text plain headers" "Html tags supported"
Thanks, Bill

I think there is a bug when initializing the options values, the two options should be available, I will fix it. A workaround to change the two options : If you change your choice from "customized header reply" to "Standard Thunderbird reply header" and next choose again "customized header reply" , the two options are available.

This is working now in version 1.7.5. Thanks!

Bill

@Duncan-Moore
Copy link

I changed the way I search the window to close in a new version 1.7.5:
https://github.com/caligraf/ChangeQuote/releases/download/1.7.5/ChangeQuote.xpi
@Duncan-Moore Could you test it ?

1.7.5 is still going wrong in the same way.
With 'forward', the window closes.
But with 'reply', the window doesn't close.

@caligraf
Copy link
Owner

@Duncan-Moore I'm trying to reproduce your problem on my side.
What are your settings in reply header part and Format and actions part ?
Do you have others extensions installed ?

@Duncan-Moore
Copy link

What are your settings in reply header part and Format and actions part ?
Do you have others extensions installed ?

'Reply header' only has 'Standard Thunderbird reply header' checked.
'Format and actions' only has 'Close message window after reply or forward' checked.
'Newsgroup reply headers' has nothing checked.
I've disabled all my other extensions, and the behaviour is still the same.

I'm using Windows 10.

@caligraf
Copy link
Owner

Can you check if there are any error messages in Error console ?

Error console can be shown using the shortcut Ctrl+Shift+J or via the Thunderbird tools menu under Developer Tools -> Error Console.

@Duncan-Moore
Copy link

Can you check if there are any error messages in Error console ?

I've copied and pasted the text from the console window - I wasn't sure if there's a better way to do this.

Double clicking the email I want to reply/forward gives:

Error: This will be removed. Use :ref:identities.getDefault instead. background.js:475
moz-extension://073f0246-57b8-456a-a282-66cdd2a54a1c/background.js:475
TypeError: mailIdentity is null background.js:476:20

Forwarding the email (which does close the old window) gives:

window.controllers/Controllers is deprecated. Do not use it for UA detection. 2 blank

Replying to the email (which doesn't close the old window) gives:

window.controllers/Controllers is deprecated. Do not use it for UA detection. 2 blank
Error: This will be removed. Use :ref:identities.getDefault instead. background.js:312
doHandleCommand moz-extension://073f0246-57b8-456a-a282-66cdd2a54a1c/background.js:312
Error: mailIdentity is null compose.js:176:17
updateMessage moz-extension://073f0246-57b8-456a-a282-66cdd2a54a1c/compose.js:176
Error: mailIdentity is null compose.js:176:17
updateMessage moz-extension://073f0246-57b8-456a-a282-66cdd2a54a1c/compose.js:176

@caligraf
Copy link
Owner

I understood the problem, it is the case when there is no default identity configured.
I did a fix, here is a new version 1.7.6
https://github.com/caligraf/ChangeQuote/releases/download/1.7.6/ChangeQuote.xpi
Could you test it ?

@Duncan-Moore
Copy link

Yes, that's working.
Many thanks for all the effort you've put in to this.

@Enkidu70
Copy link

new version 1.7.6

Many tnx! Seems to work fine! 👍

@BillH99999
Copy link

BillH99999 commented Oct 26, 2023

Thanks for the update caligraf! 1.7.0 seems to be working great for me except for an extra [[br /]] being put at the end.
Is this a bug in 1.7.0 or do I need to change a setting somewhere?
image
Could you try the new version 17.7.3 I did:
https://github.com/caligraf/ChangeQuote/releases/download/1.7.3/ChangeQuote.xpi
I fixed linebreak option

@caligraf
That's working great now. Thanks.

Thanks, Bill

I just noticed that it works fine in mail messages when I use Reply, but is still broken in Newsgroups when I use Followup.

On Thu, Oct 26, 2023, At 01:43 PM, "xxxx" wrote: ([[br) />

My Newsgroup Reply Headers are defined like this:

image

I'm using ChangeQuote version 1.7.6.

Bill

@caligraf
Copy link
Owner

I have released a new version, 1.7.9 the issue for newsgroups should be fixed :
https://github.com/caligraf/ChangeQuote/releases/download/1.7.9/ChangeQuote.xpi

@BillH99999
Copy link

I have released a new version, 1.7.9 the issue for newsgroups should be fixed : https://github.com/caligraf/ChangeQuote/releases/download/1.7.9/ChangeQuote.xpi

Working fine now. Thanks @caligraf

Bill

@BillH99999
Copy link

@caligraf

I think I'm seeing a minor bug (unless I'm just doing something wrong).

If I set my reply header to "On %%5, %%6 wrote:"
and my date to "%LD, %LM %d, %Y, at %h:%i %A"

my resuling header in the reply has a capital "A" in the word "at" rather than a lower case "a".

Example: On Friday, October 27, 2023, At 02:39 PM, caligraf wrote:

Thanks,
Bill

@Mart1n6
Copy link

Mart1n6 commented Oct 30, 2023

I can see as recipients only name now, not address like before... its a bug? It is also somehow possible again recipients as only address?

It is possible combination name and address? name

Thanks Martin

@caligraf
Copy link
Owner

it is a bug, I made a fix, here is a new version 1.7.10
could you test it ?
https://github.com/caligraf/ChangeQuote/releases/download/1.7.10/ChangeQuote.xpi

@BillH99999 This version also fixes the bug of "A" in uppercase instead of lowercase in reply header

@BillH99999
Copy link

@BillH99999 This version also fixes the bug of "A" in uppercase instead of lowercase in reply header

@caligraf,

I can confirm that the "a" is now in lower case.

Thanks!
Bill

@Mart1n6
Copy link

Mart1n6 commented Oct 31, 2023

it is a bug, I made a fix, here is a new version 1.7.10 could you test it ? https://github.com/caligraf/ChangeQuote/releases/download/1.7.10/ChangeQuote.xpi

Great, I see as recipients address now when I use %%2

But sometimes I see only address and sometimes combination name and address, I do not know why not only one or second option, maybe it is due how Thunderbird show contacts? But anyway I am satisfied 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants