Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching to https://identifiers.org/ URI or CURIEs #97

Open
matthias-samwald opened this issue May 7, 2021 · 2 comments · May be fixed by #122
Open

Consider switching to https://identifiers.org/ URI or CURIEs #97

matthias-samwald opened this issue May 7, 2021 · 2 comments · May be fixed by #122
Assignees
Labels

Comments

@matthias-samwald
Copy link

Looking at the currently used identifiers, it seems to be a mixture of OBO PURLs and ad-hoc solutions for some of the molecular entities. identifiers.org identifiers should make it possible to elegantly cover everything (either URI or CURIEs -- the latter would be more compact, but of course might be less ideal with OWL tools).

@callahantiff
Copy link
Owner

Hi, @matthias-samwald thanks for your interest PheKnowLator! 😄

We are currently using a mixture of URIs, those that come with each ontology (most are OBO PURLs) and the non-OBO PURLs we add for other sources. For the latter, we have opted to choose the primary identifier that is recommended for that source.

Happy to accommodate other solutions and your suggestions would certainly make things more elegant (and easier to write programs against 👩‍💻 ). I also can't think of any negative consequences to our current workflow for either option you suggest. Let me discuss this with the rest of the team and get back to you next week.

@callahantiff
Copy link
Owner

callahantiff commented Dec 6, 2021

After taking time to think about this and to review available resources for identifier resolution, we have decided to give Bioregistry a try, which also happens to include identifiers.org as a provider. This will still enable us to address the same types of issues that were highlighted above and will more easily integrate with the existing Python framework.

Please let me know if you see any major issues with this. Thank you!

@callahantiff callahantiff linked a pull request Dec 8, 2021 that will close this issue
@callahantiff callahantiff linked a pull request Dec 8, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants