Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Respect .forceIgnore #2

Closed
ralphcallaway opened this issue Sep 26, 2019 · 6 comments
Closed

Improvement: Respect .forceIgnore #2

ralphcallaway opened this issue Sep 26, 2019 · 6 comments

Comments

@ralphcallaway
Copy link
Collaborator

if someone wanted to store something else in a force.com package folder (i.e. selenium tests) that isn't subject to the compile on save, pull/push commands, seems like it would be expected this command would respect .forceIgnore

@ChuckJonas
Copy link
Collaborator

ChuckJonas commented Sep 26, 2019

I haven't used .forceIngore to fully understand the sytnax... Here's the docs.

It's not immediately obvious to me if it's just using glob patterns or actually taking a more metadata context aware approach.

If it is just using globs, npm ignore makes it super easy to check

@ralphcallaway
Copy link
Collaborator Author

oh good question, i'd assumed it was globs, but can't say for sure. my reading of the docs doesn't seem to conflict with it being implemented with globs, i guess you could crack open the dependencies for the four commands that utilize .forceIgnore if this came up

but honestly this feels like a feature that wouldn't matter until there is fairly widespread usage, guessing there aren't a ton of people putting non-sfdx files in a sfdx folder

@ralphcallaway
Copy link
Collaborator Author

i.e. sample syntax is all "globby"

# Specify a relative path to a directory from the project root
helloWorld/main/default/classes

# Specify a wildcard directory - any directory named “classes” is excluded
**classes

# Specify file extensions
**.cls
**.pdf

# Specify a specific file
helloWorld/main/default/HelloWorld.cls

@ChuckJonas
Copy link
Collaborator

Made a pass... 9225647

Needs more testing

@ChuckJonas
Copy link
Collaborator

included in 0.0.4

Pretty limited testing

@ralphcallaway
Copy link
Collaborator Author

seems to be working well, had a clean failing due to merge conflict artifacts, added **.orig to .forceIgnore and was able to run without having to track down all the artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants