[Joy] Replace row prop with orientation prop in all Joy UI components
#35721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbjORbj
changed the title
row prop to orientation in all Joy UI componentsrow prop with orientation prop in all Joy UI components
hbjORbj
added
breaking change
package: joy-ui
hbjORbj
changed the title
row prop with orientation prop in all Joy UI componentsrow prop with orientation prop in all Joy UI components
@mui/joy: parsed: +0.17% , gzip: +0.05% |
hbjORbj
changed the title
row prop with orientation prop in all Joy UI componentsrow prop with orientation prop in all Joy UI components
siriwatknp
reviewed
Jan 5, 2023
siriwatknp
reviewed
Jan 5, 2023
There was a problem hiding this comment.
@hbjORbj Can you check Argos change again? I look wrong to me.
siriwatknp
reviewed
Jan 5, 2023
hbjORbj
force-pushed
the
joy/rename-row-prop
branch
from
059e0a3
to
ee92b12
Compare
github-actions
bot
added
the
PR: out-of-date
hbjORbj
force-pushed
the
joy/rename-row-prop
branch
from
2347621
to
dcc8efd
Compare
hbjORbj
force-pushed
the
joy/rename-row-prop
branch
from
dcc8efd
to
dac5ee3
Compare
github-actions
bot
removed
the
PR: out-of-date
hbjORbj
force-pushed
the
joy/rename-row-prop
branch
from
a1b9ca8
to
dac5ee3
Compare
siriwatknp
approved these changes
Jan 24, 2023
siriwatknp
requested changes
Jan 24, 2023
There was a problem hiding this comment.
@hbjORbj Please recheck the docs and replace row with orientation, e.g. in https://deploy-preview-35721--material-ui.netlify.app/joy-ui/react-list/#horizontal-list.
Can't understand why I couldn't spot them. Thanks Thanks :)
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
rowprop (of boolean type) withorientationprop (of type 'horizontal' or 'vertical') inCard,List,RadioGroupand some internal components relevant toRadioGrouprowprop withorientationprop in instances of components in Joy demosorientationprop to have eitherverticalorhorizontalclassname