Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React.PropTypes error in Slider Component #4890

Closed
edcs opened this issue Aug 3, 2016 · 3 comments
Closed

React.PropTypes error in Slider Component #4890

edcs opened this issue Aug 3, 2016 · 3 comments
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module!

Comments

@edcs
Copy link

edcs commented Aug 3, 2016

I've just updated to material-ui@^0.15.3 so I can get the fixes for the React.PropTypes warnings that have just shown up. This release seems to have fixed most the problems, but I'm still getting the problem with the Slider component.

This code:

return (
    <Slider
        value={this.props.pagination.current_page}
        step={1}
        min={1}
        max={this.props.pagination.total_pages}
        onChange={(event, value) => this.refreshTable({ page: value })}
    />
);

Produces these warnings:

bundle.js:10080 Warning: You are manually calling a React.PropTypes validation function for the `defaultValue` prop on `Slider`. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.warning @ bundle.js:10080checkType @ bundle.js:12566valueInRangePropType @ bundle.js:76645checkReactTypeSpec @ bundle.js:12390validatePropTypes @ bundle.js:12029createElement @ bundle.js:12063paginationSlider @ bundle.js:75990render @ bundle.js:76059_renderValidatedComponentWithoutOwnerOrContext @ bundle.js:24877_renderValidatedComponent @ bundle.js:24904_updateRenderedComponent @ bundle.js:24827_performComponentUpdate @ bundle.js:24798updateComponent @ bundle.js:24715receiveComponent @ bundle.js:24609receiveComponent @ bundle.js:16511_updateRenderedComponent @ bundle.js:24829_performComponentUpdate @ bundle.js:24798updateComponent @ bundle.js:24715performUpdateIfNecessary @ bundle.js:24623performUpdateIfNecessary @ bundle.js:16545runBatchedUpdates @ bundle.js:16137perform @ bundle.js:17456perform @ bundle.js:17456perform @ bundle.js:16076flushBatchedUpdates @ bundle.js:16159closeAll @ bundle.js:17522perform @ bundle.js:17469batchedUpdates @ bundle.js:26653enqueueUpdate @ bundle.js:16187enqueueUpdate @ bundle.js:25624enqueueSetState @ bundle.js:25809ReactComponent.setState @ bundle.js:10518handleChange @ bundle.js:31074dispatch @ bundle.js:31458(anonymous function) @ bundle.js:34276dispatch @ bundle.js:32018(anonymous function) @ bundle.js:33289asap.flush @ bundle.js:33594asap @ bundle.js:33582runPutEffect @ bundle.js:33286runEffect @ bundle.js:33240next @ bundle.js:33124currCb @ bundle.js:33194
bundle.js:10080 Warning: You are manually calling a React.PropTypes validation function for the `max` prop on `Slider`. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.warning @ bundle.js:10080checkType @ bundle.js:12566minMaxPropType @ bundle.js:76628checkReactTypeSpec @ bundle.js:12390validatePropTypes @ bundle.js:12029createElement @ bundle.js:12063paginationSlider @ bundle.js:75990render @ bundle.js:76059_renderValidatedComponentWithoutOwnerOrContext @ bundle.js:24877_renderValidatedComponent @ bundle.js:24904_updateRenderedComponent @ bundle.js:24827_performComponentUpdate @ bundle.js:24798updateComponent @ bundle.js:24715receiveComponent @ bundle.js:24609receiveComponent @ bundle.js:16511_updateRenderedComponent @ bundle.js:24829_performComponentUpdate @ bundle.js:24798updateComponent @ bundle.js:24715performUpdateIfNecessary @ bundle.js:24623performUpdateIfNecessary @ bundle.js:16545runBatchedUpdates @ bundle.js:16137perform @ bundle.js:17456perform @ bundle.js:17456perform @ bundle.js:16076flushBatchedUpdates @ bundle.js:16159closeAll @ bundle.js:17522perform @ bundle.js:17469batchedUpdates @ bundle.js:26653enqueueUpdate @ bundle.js:16187enqueueUpdate @ bundle.js:25624enqueueSetState @ bundle.js:25809ReactComponent.setState @ bundle.js:10518handleChange @ bundle.js:31074dispatch @ bundle.js:31458(anonymous function) @ bundle.js:34276dispatch @ bundle.js:32018(anonymous function) @ bundle.js:33289asap.flush @ bundle.js:33594asap @ bundle.js:33582runPutEffect @ bundle.js:33286runEffect @ bundle.js:33240next @ bundle.js:33124currCb @ bundle.js:33194
bundle.js:10080 Warning: You are manually calling a React.PropTypes validation function for the `min` prop on `Slider`. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.warning @ bundle.js:10080checkType @ bundle.js:12566minMaxPropType @ bundle.js:76628checkReactTypeSpec @ bundle.js:12390validatePropTypes @ bundle.js:12029createElement @ bundle.js:12063paginationSlider @ bundle.js:75990render @ bundle.js:76059_renderValidatedComponentWithoutOwnerOrContext @ bundle.js:24877_renderValidatedComponent @ bundle.js:24904_updateRenderedComponent @ bundle.js:24827_performComponentUpdate @ bundle.js:24798updateComponent @ bundle.js:24715receiveComponent @ bundle.js:24609receiveComponent @ bundle.js:16511_updateRenderedComponent @ bundle.js:24829_performComponentUpdate @ bundle.js:24798updateComponent @ bundle.js:24715performUpdateIfNecessary @ bundle.js:24623performUpdateIfNecessary @ bundle.js:16545runBatchedUpdates @ bundle.js:16137perform @ bundle.js:17456perform @ bundle.js:17456perform @ bundle.js:16076flushBatchedUpdates @ bundle.js:16159closeAll @ bundle.js:17522perform @ bundle.js:17469batchedUpdates @ bundle.js:26653enqueueUpdate @ bundle.js:16187enqueueUpdate @ bundle.js:25624enqueueSetState @ bundle.js:25809ReactComponent.setState @ bundle.js:10518handleChange @ bundle.js:31074dispatch @ bundle.js:31458(anonymous function) @ bundle.js:34276dispatch @ bundle.js:32018(anonymous function) @ bundle.js:33289asap.flush @ bundle.js:33594asap @ bundle.js:33582runPutEffect @ bundle.js:33286runEffect @ bundle.js:33240next @ bundle.js:33124currCb @ bundle.js:33194
bundle.js:10080 Warning: You are manually calling a React.PropTypes validation function for the `value` prop on `Slider`. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

I guess the slider component was missed when the other components were patched? I would raise a PR for this but I'm a bit unfamiliar with what's going on here.

Versions

  • Material-UI: 0.15.3
  • React: 15.3.0
  • Browser: Chrome
@oliviertassinari oliviertassinari added this to the 0.15.4 milestone Aug 3, 2016
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Aug 3, 2016
@oliviertassinari
Copy link
Member

@edcs Thanks for raising it. It should have been fixed by #4869.

@leandrooriente
Copy link

@oliviertassinari not yet

React: 15.3.0
Material-ui: 0.15.3
Mac OS: 10.11.6
Chrome: 51.0.2704.103 (64-bit)

warning.js:44 Warning: You are manually calling a React.PropTypes validation function for the `defaultValue` prop on `Slider`. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

warning.js:44 Warning: You are manually calling a React.PropTypes validation function for the `max` prop on `Slider`. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

warning.js:44 Warning: You are manually calling a React.PropTypes validation function for the `min` prop on `Slider`. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

warning.js:44 Warning: You are manually calling a React.PropTypes validation function for the `value` prop on `Slider`. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 5, 2016

The fix hasn't been released to npm yet.

@oliviertassinari oliviertassinari added the component: slider This is the name of the generic UI component, not the React module! label Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants