Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField] 16.4 inputStyle no longer applies styles to input #5737

Closed
jbhatab opened this issue Dec 8, 2016 · 7 comments
Closed

[TextField] 16.4 inputStyle no longer applies styles to input #5737

jbhatab opened this issue Dec 8, 2016 · 7 comments
Labels
component: text field This is the name of the generic UI component, not the React module!

Comments

@jbhatab
Copy link

jbhatab commented Dec 8, 2016

Description

I upgraded from 16.1 to 16.4 and my text field changed styles. inputStyle no longer works.

Images & references

inputStyle: {
fontSize: 13,
marginTop: 9,
}

<TextField
className={className}
disabled={disabled || false}
errorText={errorText}
floatingLabelFixed={true}
floatingLabelStyle={inlineStyles.floatingLabelStyle}
floatingLabelText={label}
fullWidth={true}
hintStyle={inlineStyles.hintStyle}
hintText={placeholder}
inputStyle={inlineStyles.inputStyle}
name={name}
onChange={onChange}
style={inlineStyles.wrapperStyle}
type={type || 'text'}
value={value}
/>
-->

Versions

  • Material-UI: 16.4
  • React: 15.4.1
  • Browser: chrome
@oliviertassinari oliviertassinari added component: text field This is the name of the generic UI component, not the React module! and removed component: text field This is the name of the generic UI component, not the React module! labels Dec 18, 2016
@giulianojjk
Copy link

I'm experimenting the same issue with the 0.16.7.
I believe it applies also to DatePicker and TimePicker textFieldStyle property.

As a workaround I set a class "biggerInput" to the components using the following CSS:

.biggerInput input {
font-size: 140% !important;
}
.biggerInput textarea {
font-size: 140% !important;
}

But this is a very bad solution.
I hope it can be solved soon!

Thank you for the help!
Giuliano

@oliviertassinari
Copy link
Member

We have been porting the component on the next branch. We reimplemented it from the ground-up. While we haven't tested it, I think that the issue is most likely fixed on that branch. Hence, I'm closing it.

@oliviertassinari
Copy link
Member

Let's reopen this issue, regressions are bad, even with the alpha version, I would rather see this one fixed.

@oliviertassinari
Copy link
Member

Latest feedback from @blevine

Confirmed that this works in 0.18.0, but not 0.18.3. Thanks @WillowHQ

@oliviertassinari
Copy link
Member

Let's close for the new component on the v1-beta branch.

@mhemrg
Copy link

mhemrg commented Apr 13, 2018

@oliviertassinari Same issue in ^1.0.0-beta.41.

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 13, 2018

@mhemrg https://material-ui.com/demos/text-fields/#customized-inputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

5 participants