Update for React 14

[ghost]

This is a WIP to update material-ui to React 14

[ghost]

I'm going to close this until it is more baked so the build stops spamming failures

[ghost]

zilverline/react-tap-event-plugin#34

I imagine the above needs to be resolved as well.

[oliviertassinari]

I feel like this will not work with react v0.13.x. Should we support both at the same time?

[yongxu]

+1
@oliviertassinari , I think it would be reasonable to maintain a branch that supports 0.13, but supporting both doesn't make much sense to me.

[goof03]

Sorry but how do you install this properly (for testing) ? I try
npm install https://github.com/danmartinez101/material-ui.git#react-14

but i get :
npm ERR! peerinvalid The package react@0.14.0-rc1 does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer react-addons-clone-with-props@0.14.0-rc1 wants react@^0.14.0-rc1
npm ERR! peerinvalid Peer react-addons-create-fragment@0.14.0-rc1 wants react@^0.14.0-rc1
npm ERR! peerinvalid Peer react-addons-linked-state-mixin@0.14.0-rc1 wants react@^0.14.0-rc1
npm ERR! peerinvalid Peer react-addons-pure-render-mixin@0.14.0-rc1 wants react@^0.14.0-rc1
npm ERR! peerinvalid Peer react-addons-test-utils@0.14.0-rc1 wants react@^0.14.0-rc1
npm ERR! peerinvalid Peer react-addons-transition-group@0.14.0-rc1 wants react@^0.14.0-rc1
npm ERR! peerinvalid Peer react-addons-update@0.14.0-rc1 wants react@^0.14.0-rc1
npm ERR! peerinvalid Peer react-tap-event-plugin@0.1.7 wants react@^0.14.0-rc1
npm ERR! peerinvalid Peer material-ui@0.11.0 wants react@>=0.13

[ghost]

You would need npm3 or to change the peer dependency in package.json

This pull request still needs work in that area, but I'm holding off to see if this is even desired

[s0meone]

@danmartinez101 zilverline/react-tap-event-plugin#34 is now fixed. The tap event plugin is now compatible with React 0.14. It breaks compatibility with 0.13 however. Let me know if this is a problem!

[shaurya947]

@danmartinez101 I'm not sure what the status of this PR is.

We've created a new branch to support React v0.14.0-rc1. If these changes are all still valid, could you please create a PR to that branch instead (with some explanation of the changes)? Thanks!

[ghost]

Yep, no problem, I'll go check that branch out in a bit.

Before I migrate the PR, can you provide some guidelines regarding the approach for supporting React 0.14?
Topics of import are:

• Is it expected that 0.13 still be supported?
• What will be done about the peer-dependency? Will it be removed, or updated to include both 0.13 and 0.14, or just migrated to 0.14?
• Is work to support npm@3.x.x to be included in this branch (this impacts a few dependencies)

[shaurya947]

@danmartinez101

• Ideally, yes. If we can get the react-0.14-support branch to work across React 0.13 and the pre-release versions of 0.14, that would be super. Although I don't know how realistic that is at this point. If we can't support both, then this branch shall be dedicated to React 0.14, of course.
• Following from the above point, in the ideal case we would like to update it to support both 0.13 and 0.14 right now. Once a stable version of React 0.14 is released, it probably won't be long before we bump it up altogether.
• As of this moment, we haven't really started thinking about npm 3 support. So I doubt that this branch will be expecting changes related to that anytime soon -- just my guess :)

[ghost]

I'll close this as I've noticed @oliviertassinari has a couple of PRs that address this in a backwards compatible way. Those PRs will work until at least 0.15 and will allow for consumers that don't want to upgrade to 0.14 as well as those that do.