Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React v0.14 #1751

Merged
merged 3 commits into from
Sep 29, 2015
Merged

React v0.14 #1751

merged 3 commits into from
Sep 29, 2015

Conversation

oliviertassinari
Copy link
Member

Use #1733.

  • The docs site is still broken, we need to fix react-router
  • We have some warning to fix regarding deprectated usage

@shaurya947
Copy link
Contributor

@oliviertassinari why is the build failing? Does this PR need more work before it can be merged?

@oliviertassinari
Copy link
Member Author

@shaurya947 That an issue with npm. I still need to fix it. Well, I would say that we need to fix the docs.

@shaurya947
Copy link
Contributor

@oliviertassinari okay. Holding off until issues are fixed.

@oliviertassinari
Copy link
Member Author

@shaurya947
Copy link
Contributor

Aah gotcha @oliviertassinari

@oliviertassinari
Copy link
Member Author

I'm gonna clone react-stub-context inside mui. We will have to remove it once they support react 14

@oliviertassinari
Copy link
Member Author

@shaurya947 This should be working now. I'm gonna see If I can fix the docs site. Looks like it's mainly fixing the breaking changes of react-router.

@shaurya947
Copy link
Contributor

Do you want me to merge this and you can create a separate PR for the docs site? @oliviertassinari

@oliviertassinari
Copy link
Member Author

@shaurya947 I have fixed the home screen of the docs, however, links are broken, etc, ...
See https://github.com/rackt/react-router/blob/master/UPGRADE_GUIDE.md for the migration.
I think that we can merge this one. Still more work is needed

shaurya947 added a commit that referenced this pull request Sep 29, 2015
@shaurya947 shaurya947 merged commit 0422205 into mui:react-0.14-support Sep 29, 2015
@shaurya947
Copy link
Contributor

Thanks @oliviertassinari! Looking forward to a fix with new react-router code :)

@ashtonsix
Copy link

Perfect! I'll be making some pull requests once material-ui is compatiable w/ 0.14

@cgestes
Copy link
Contributor

cgestes commented Sep 29, 2015

Can help with react-router. I did the transition for my project some days ago. feel free to ping me on gitter. The upgrade doc is well done.

I'am also willing to help for testing. Will checkout and test tomorrow.

@shaurya947
Copy link
Contributor

That would be much appreciated @cgestes :-)

Room on gitter is called shaurya947/react-router-fix

@oliviertassinari
Copy link
Member Author

@cgestes Any idea with the url is http://0.0.0.0:3000/#/?_k=5nnd1y when we go to http://0.0.0.0:3000?

Solution : I need createBrowserHistory

@cgestes
Copy link
Contributor

cgestes commented Sep 30, 2015

I have the same :)

here are some info: remix-run/react-router#1967

@cgestes
Copy link
Contributor

cgestes commented Sep 30, 2015

Do we need all commits for a dev branch to pass all the tests like in master?

Maybe it would make sense to merge commits to react-0.14 branch if they look wanted and decent, so that we can try them easily, and provide correction easily.

And we take more care that everything is alright before merging to master?

@oliviertassinari
Copy link
Member Author

@cgestes Thanks. Here is the fix #1766 for one of the issues with react-router.

@cgestes
Copy link
Contributor

cgestes commented Sep 30, 2015

looks like commit enterred the branch already, forget the previous comment, I'am trying right now :)

@oliviertassinari oliviertassinari deleted the react-v0.14 branch November 3, 2015 10:51
@zannager zannager added the docs Improvements or additions to the documentation label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants