[TextField] Fix width issue #6096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
component: text field
rosskevin
previously requested changes
Feb 9, 2017
| }, | ||
| input: { | ||
| margin: 10, | ||
| }, | ||
| largeInput: { | ||
| margin: 10, | ||
| width: 300, |
There was a problem hiding this comment.
I would omit largeInput here and use the same input class. Add it to the outer: { width: 300 } to the outermost <div/>, it would better prove that the width fills the given space.
oliviertassinari
force-pushed
the
text-field-width
branch
from
00a2f3a
to
97f18dc
Compare
rosskevin
suggested changes
Feb 9, 2017
| ref={(c) => { this.focusInput = c; }} | ||
| className={classes.input} | ||
| value="Large input" | ||
| className={classNames(classes.input, classes.large)} |
There was a problem hiding this comment.
That won't work, the <Input /> do not grow by default. Here is the output with what you are suggesting:
Here is the same output by using <input /> intead of <Input />.
There was a problem hiding this comment.
ah, I must have something different in my app, you are right with your original code.
| value="Error" | ||
| className={classes.input} | ||
| /> | ||
| <div> |
There was a problem hiding this comment.
You might rename large to outerContainer
oliviertassinari
force-pushed
the
text-field-width
branch
from
97f18dc
to
8ce1749
Compare
rosskevin
approved these changes
Feb 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5834.