[docs] Optional style sheet name #7594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Generate a new style sheet that represents the style you want to inject in the DOM. | ||
|
|
||
| #### Arguments | ||
|
|
||
| 1. `name` (*String*): The name of the style sheet. Useful for debugging. | ||
| 1. `name` (*String* [optional]): The name of the style sheet. Useful for debugging. | ||
| If the value isn't provided, we will try to fallback to the name of the component. |
| meta = currentStyleSheet.name ? currentStyleSheet.name : getDisplayName(BaseComponent); | ||
| // Sanitize the string as will be used in development to prefix the generated | ||
| // class name. | ||
| meta = meta.replace(new RegExp(/[!"#$%&'()*+,./:;<=>?@[\\\]^`{|}~]/g), '-'); |
There was a problem hiding this comment.
@kof point of interest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have seen too many people copy pasting the same component template and forgetting to rename the sheet name. Wouldn't it be better if we could rely on the component name to get a nice debuggable class name in development?
That's what this PR is about:
and in development, the class name is correct:
in production we still have the following:
P.S. I have been using the following regexp on the codebase:
createStyleSheet\('((?!Mui)\w+)',.