Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ButtonBase] Explicit the need for a class component #7656

Merged
merged 1 commit into from Aug 3, 2017
Merged

[ButtonBase] Explicit the need for a class component #7656

merged 1 commit into from Aug 3, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 3, 2017 •
edited

A small issue I have noticed implementing a custom link for a button.

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module! v1 labels Aug 3, 2017
@oliviertassinari oliviertassinari merged commit 3e405dc into mui:v1-beta Aug 3, 2017
@oliviertassinari oliviertassinari deleted the button-function branch August 3, 2017 19:01
sebald pushed a commit to PTW-Freiburg/material-ui that referenced this pull request Aug 7, 2017
@oliviertassinari
[ButtonBase] Explicit the need for a class component (mui#7656)
d6a6d77
sebald pushed a commit to PTW-Freiburg/material-ui that referenced this pull request Aug 7, 2017
Merge remote-tracking branch 'upstream/v1-beta' into v1-beta
5c6c0e7 
* upstream/v1-beta:
  [Modal] Fix with react@next (mui#7673)
  Typo fix 'accross' to 'across' (mui#7671)
  v1.0.0-beta.4
  [CHANGELOG] Prepare 1.0.0-beta.4
  [typescript] Improve the coverage (mui#7606)
  [Modal] Take into account the body margin (mui#7666)
  Fixes in the subway (mui#7661)
  [flow] export type Props for composability (mui#7609)
  [ButtonBase] Explicit the need for a class component (mui#7656)
  [Eslint] Spell check config (mui#7643)
  [ListItemText] Repurpose text class (mui#7645)
  [GridList] migrate to next branch (mui#7626)
  [Typo] Correct words spelling v1 (mui#7641)
  Update docs for <RadioGroup> (mui#7640)
  Fixed "initial" word
sebald pushed a commit to PTW-Freiburg/material-ui that referenced this pull request Aug 7, 2017
Merge branch 'v1-beta' into setup-typings-tests
1a53023 
* v1-beta:
  [Modal] Fix with react@next (mui#7673)
  Typo fix 'accross' to 'across' (mui#7671)
  v1.0.0-beta.4
  [CHANGELOG] Prepare 1.0.0-beta.4
  [typescript] Improve the coverage (mui#7606)
  [Modal] Take into account the body margin (mui#7666)
  Fixes in the subway (mui#7661)
  [flow] export type Props for composability (mui#7609)
  [ButtonBase] Explicit the need for a class component (mui#7656)
  [Eslint] Spell check config (mui#7643)
  [ListItemText] Repurpose text class (mui#7645)
  [GridList] migrate to next branch (mui#7626)
  [Typo] Correct words spelling v1 (mui#7641)
  Update docs for <RadioGroup> (mui#7640)
  Fixed "initial" word
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: button This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@oliviertassinari