Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table] Add the possibility of custom element type #7765

Merged
merged 1 commit into from Aug 15, 2017
Merged

[Table] Add the possibility of custom element type #7765

merged 1 commit into from Aug 15, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 15, 2017 •
edited

needed this to implement with react-virtualized because of non valide dom nesting.

Reset #7754 of @wieseljonas.

@rosskevin This PR is going to make you happy, some new components migrated to flow 馃帀

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari changed the title Adding the possibility of custom element type on Table components [Table] Add the possibility of custom element type Aug 15, 2017
@oliviertassinari oliviertassinari added the component: table This is the name of the generic UI component, not the React module! label Aug 15, 2017
@oliviertassinari oliviertassinari merged commit b3200ce into mui:v1-beta Aug 15, 2017
@oliviertassinari oliviertassinari deleted the table-flow branch August 15, 2017 17:51
@oliviertassinari
Copy link
Member Author

@wieseljonas Thanks :)

@oliviertassinari oliviertassinari mentioned this pull request Aug 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: table This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oliviertassinari @wieseljonas