Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not good 馃檲. We had
sheets.js
keeping a reference to all the create sheets. This can be an important leak.When calling
createStyleSheet()
, aStyleSheet
is created. The constructor is adding itself tojss/sheets.js
. But it's not removed when calling.detach()
.So, we need to call removeStyleSheet() to be detached from
jss/sheets.js
.Closes #8019