Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masks: allow more than one week with 'calendar_week' padding #89

Closed
sjpfenninger opened this issue Mar 23, 2018 · 1 comment
Closed

Comments

@sjpfenninger
Copy link
Member

Problem description

Currently, we prevent masking with extreme or extreme_diff when selecting length other than 1D and n other than 1 by raising a ValueError:

# Will raise a ValueError
mask = masks.extreme(
    data, 'csp', var='resource', how='max',
    length='1D', n=2, padding='calendar_week'
)

Steps to reproduce the problem

There is an inconsistency in processing more than a single day in _extreme_with_padding which needs to be addressed for the ValueError check to be removed.

@sjpfenninger
Copy link
Member Author

Will be addressed by #356

@sjpfenninger sjpfenninger removed this from the 0.7.0 milestone May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants