Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 #31

Closed
callmecavs opened this issue May 14, 2016 · 6 comments
Closed

v1.0.0 #31

callmecavs opened this issue May 14, 2016 · 6 comments

Comments

@callmecavs
Copy link
Owner

callmecavs commented May 14, 2016

Is on the way!

The following will absolutely be included:

  1. follow the singleton pattern, and take a purely functional approach (no instantiation necessary)
  2. accessibility, behind an option (boolean/flag), because it requires CSS to prevent a default blue outline from showing on the element that's scrolled to
  3. unminified version of dist file
  4. better target resolution (accept px value, node or CSS selector) - Update jump.js #30, Fixed error when using string as selector #29

The following are under consideration:

  • support scrolling within an element (aka not the window object)
    • may bloat the lib, by requiring a different "top of element" calculation, and different loop to scroll the container element

I cant thank the users of this library enough for making it as popular as it is - please leave your thoughts, and feature requests, on this issue. and please dont take offense to me closing your issue/pull request - hopefully ive addressed it here (or left if open).

its easier for me to have everything under "one roof". cheers to all 🍻

follow the progress on the v1.0.0 branch

@callmecavs
Copy link
Owner Author

callmecavs commented May 14, 2016

update: 1, 2, and 4 are done. see the v1.0.0 branch

the dist file is almost half the size (1.44kb vs 2.7kb) - compliments of the functional approach, and upgraded build system

the gulpfile is now using rollup by @Rich-Harris. find more by him on GitHub, and on GitLab

@mgiulio
Copy link

mgiulio commented May 14, 2016

+1 :)

If I'll be able to find some time I'll try to help.

@callmecavs
Copy link
Owner Author

callmecavs commented May 14, 2016

@mgiulio you already helped by writing the SitePoint article. using the singleton pattern was your idea. it made so much sense, i had to implement it in v1.0.0

i appreciate both the article, and the thinking about how the library could be better. you'll be mentioned in the v1.0.0 release notes

@mrksbnch
Copy link

Personally, I would love to see support for scrolling within an element. I don't see why this would bloat the library though. Instead of scrollTo(), you'd have to use scrollTop, but that's most likely done in a couple of extra lines. If it helps, I could create a pull request for this feature in the v1.0.0 branch.

@martin-svk
Copy link

What is the timeline in which we can expect the release of 1.0? Thanks

@callmecavs
Copy link
Owner Author

@mgiulio @mrksbnch @martin-svk its been released! see the release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants