fix: support evaluating TypeScript files by default. fixes #27 #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
force-pushed
the
@satya164/resolve-typescript
branch
2 times, most recently
from
db661f7
to
bf121b9
Compare
thymikee
approved these changes
Dec 16, 2018
| @@ -58,10 +59,35 @@ class Module { | |||
| this.require.resolve = this.resolve.bind(this); | |||
| this.require.ensure = NOOP; | |||
| this.require.cache = cache; | |||
|
|
|||
| // We support following extensions by default | |||
| this.extensions = ['.json', '.js', '.ts', '.tsx']; | |||
There was a problem hiding this comment.
add .jsx as well? I'm cool with not adding that and forcing others to just use .js though :D
There was a problem hiding this comment.
Should kill .tsx as well then XD
There was a problem hiding this comment.
@thymikee I would if I could. But due to syntax ambiguity with deprecated typecast syntax, TypeScript relies on the .tsx extension to understand JSX!
There was a problem hiding this comment.
What a shame. Flow doesn't have these issues :D Hopefully they can get rid of deprecations soon 🙂
src/babel/module.js
Outdated
| @@ -86,15 +112,16 @@ class Module { | |||
| // we would end up in infinite loop with cyclic dependencies | |||
| cache[filename] = m; | |||
|
|
|||
| if (/\.(js|json)$/.test(filename)) { | |||
| // For JS/JSON files, we need to read the file first | |||
| if (/\.(json|js|tsx?)$/.test(filename)) { | |||
There was a problem hiding this comment.
I think it's safer to generate this regex based on this.extensions, but that's not gonna change too often, so feel free to ignore this advice
satya164
force-pushed
the
@satya164/resolve-typescript
branch
from
bf121b9
to
449a816
Compare
zamotany
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.