New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work within a ScrollView #784
Comments
@diegowendel diegowende |
Thanks @marceloch2! Got it working with a version change as well 👍 |
what you version ? |
Hi @plugato Mine is "react-native-pager-view": "7.0.0-rc.0". Hope that's helps. |
@marceloch2 @diegowendel When I update to 7.0.0-rc.1, I get the following error:
Do you know what could be wrong on my setup? I'm using RN v0.73.3 |
+1 any solution? |
Could you please check this example https://github.com/callstack/react-native-pager-view/blob/master/example/src/ScrollablePagerViewExample.tsx , if does not work as well? |
I tried it and couldn't get it to work in an iOS. I must say that I copied the example into a custom playground with I got the following errors: 1: When using the 2: When removing the Screen.Recording.2024-04-04.at.12.11.23.mov |
Got the same issue. Solved by manually patching the export names: diff --git a/node_modules/react-native-pager-view/src/LEGACY_PagerViewNativeComponent/LEGACY_PagerViewNativeComponent.ts b/node_modules/react-native-pager-view/src/LEGACY_PagerViewNativeComponent/LEGACY_PagerViewNativeComponent.ts
index 4770da9..326fe5f 100644
--- a/node_modules/react-native-pager-view/src/LEGACY_PagerViewNativeComponent/LEGACY_PagerViewNativeComponent.ts
+++ b/node_modules/react-native-pager-view/src/LEGACY_PagerViewNativeComponent/LEGACY_PagerViewNativeComponent.ts
@@ -67,7 +67,7 @@ interface NativeCommands {
) => void;
}
-export const LEGACY_PagerViewNativeCommands: NativeCommands =
+export const Commands: NativeCommands =
codegenNativeCommands<NativeCommands>({
supportedCommands: [
'setPage',
diff --git a/node_modules/react-native-pager-view/src/PagerView.tsx b/node_modules/react-native-pager-view/src/PagerView.tsx
index d2bfec5..5e44bcc 100644
--- a/node_modules/react-native-pager-view/src/PagerView.tsx
+++ b/node_modules/react-native-pager-view/src/PagerView.tsx
@@ -9,7 +9,7 @@ import {
} from './utils';
import PagerViewNativeComponent, {
- PagerViewNativeCommands,
+ Commands as PagerViewNativeCommands,
OnPageScrollEventData,
OnPageScrollStateChangedEventData,
OnPageSelectedEventData,
@@ -17,7 +17,7 @@ import PagerViewNativeComponent, {
} from './PagerViewNativeComponent/PagerViewNativeComponent';
import LEGACY_PagerViewNativeComponent, {
- LEGACY_PagerViewNativeCommands,
+ Commands as LEGACY_PagerViewNativeCommands,
} from './LEGACY_PagerViewNativeComponent/LEGACY_PagerViewNativeComponent';
/**
diff --git a/node_modules/react-native-pager-view/src/PagerViewNativeComponent/PagerViewNativeComponent.ts b/node_modules/react-native-pager-view/src/PagerViewNativeComponent/PagerViewNativeComponent.ts
index 9017e53..7d520b0 100644
--- a/node_modules/react-native-pager-view/src/PagerViewNativeComponent/PagerViewNativeComponent.ts
+++ b/node_modules/react-native-pager-view/src/PagerViewNativeComponent/PagerViewNativeComponent.ts
@@ -56,7 +56,7 @@ export interface NativeCommands {
) => void;
}
-export const PagerViewNativeCommands: NativeCommands =
+export const Commands: NativeCommands =
codegenNativeCommands<NativeCommands>({
supportedCommands: [
'setPage', |
@leethree |
Thank you @leethree so much ❤️ Once pipeline pass, I will merge it |
Did you solve this? I'm facing it too. |
@Kamill90 will take a look at it in his free time 💪 |
@AgustinMJ I'm still seeing the same invariant violation as of 6.3.1. Did you end up patching? |
Environment
Set up a project and copy the snippet available below.
Description
PagerView component does not work when inside of a ScrollView.
Code Snippet
The text was updated successfully, but these errors were encountered: