Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] cannot close formSheet screen since 6.2.0 #800

Open
rvasseur31 opened this issue Dec 14, 2023 · 0 comments
Open

[ios] cannot close formSheet screen since 6.2.0 #800

rvasseur31 opened this issue Dec 14, 2023 · 0 comments

Comments

@rvasseur31
Copy link

Environment

System:
OS: macOS 14.1.1
CPU: (8) arm64 Apple M1
Memory: 83.17 MB / 16.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 20.9.0
path: /usr/local/bin/node
Yarn:
version: 1.22.19
path: /opt/homebrew/bin/yarn
npm:
version: 10.1.0
path: /usr/local/bin/npm
Watchman:
version: 2023.10.30.00
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.14.2
path: /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.2
- iOS 17.2
- macOS 14.2
- tvOS 17.2
- watchOS 10.2
Android SDK: Not Found
IDEs:
Android Studio: 2022.3 AI-223.8836.35.2231.11090377
Xcode:
version: 15.1/15C65
path: /usr/bin/xcodebuild
Languages:
Java:
version: 11.0.21
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.72.5
wanted: 0.72.5
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false

Description

Hi !

Since the version 6.2.0, my screen with formSheet no longer wants to close when sliding up and down. This seems to have a lot to do with UIGestureRecognizer, which you added in version 6.2.0. I have the impression after some research that gesture is not considered to be an RNSPanGestureRecognizer and so we fall into the case where we return NO. I tried to resolve it from myself but I don't have enough knowledge to do it.

Reproducible Demo

To reproduce the bug, open a screen with view pager and formSheet presentation (<Stack.Screen name="FormSheet" component={FormSheetScreen} options={{presentation: "formSheet", animation: "default"}} />).

I can add a reproducible demo, but I think it can be useful to add this case to the exemple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant