Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BottomNavigation Shifting Ripple Animation Bug #1207

Closed
Moh-Kur opened this issue Jul 14, 2019 · 1 comment
Closed

BottomNavigation Shifting Ripple Animation Bug #1207

Moh-Kur opened this issue Jul 14, 2019 · 1 comment

Comments

@Moh-Kur
Copy link

Moh-Kur commented Jul 14, 2019

Hello,
There is a bug in the changing color ripple effect for less than 4 items with shifting enabled.
The center of the ripple is not centered with respect to the click.
You can see it in this example by @Trancever in #631 (comment)_

His link: https://snack.expo.io/@trensik/bottom-navigation

I tried it on multiple devices ios and android but the same bug appears.
Thanks

@Moh-Kur Moh-Kur changed the title BottomNavigation shifting animation bug BottomNavigation Shifting Ripple Animation Bug Jul 14, 2019
@michaelmalinowski
Copy link

If you have three items you can change line 699 in BottomNavigation.js from layout.width / 8, to
layout.width / 3,. This will even out the ripple effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants