Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: let users choose checkbox for Checkbox.Item #2375

Merged

Conversation

tegandbiscuits
Copy link
Contributor

Summary

This makes it so developers are able to specify which checkbox component should be used for Checkbox.Item.

My main motivation for this was that, at least for a single checkbox, the iOS checkbox is very difficult to tell there's a thing to check.

@tegandbiscuits tegandbiscuits changed the title Let users choose checkbox for Checkbox.Item feat: let users choose checkbox for Checkbox.Item Nov 23, 2020
@callstack-bot
Copy link

Hey @tegandbiscuits, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@Trancever Trancever merged commit 0ec3587 into callstack:master Nov 23, 2020
@Trancever
Copy link
Contributor

@tegandbiscuits Could you submit a similar PR but for the RadioButton.Item component?

@tegandbiscuits
Copy link
Contributor Author

@Trancever Sure thing!

@tegandbiscuits tegandbiscuits deleted the feat/add-mode-to-checkbox-item branch November 23, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants