fix: Changed sorting arrow direction in data table #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haxonadora
changed the title
|
The mobile version of example app from this branch is ready! You can see it here |
haxonadora
requested review from
Trancever and
unikvozm
and removed request for
Trancever
|
Hey @haxonadora, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
Trancever
approved these changes
Dec 16, 2020
|
Good job |
wojteg1337
approved these changes
Dec 16, 2020
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix related to issue.
According to Material design guidelines:
The downward arrow shows that the schedule column is sorted in descending order.Currently
sortDirectionprop inDataTableTitleset todescendingwas making the arrow to point up instead of down. Documentation is showing correct behaviour but the code was doing the opposite.