Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadioButton dialog should use status props. #592

Merged
merged 2 commits into from
Oct 12, 2018

Conversation

altaf933
Copy link
Contributor

This pr has used correct props in radio button dialog , earlier it was using different props instead status.

Motivation

We have make changes as per RadioButton props and use status props properties that change radio button state.

Test plan

Steps to reach out issue:-
Example -> Dialog -> Show dialog with RadioButton.

#591

@callstack-bot
Copy link

Hey @altaf933, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API.

Copy link
Contributor

@Trancever Trancever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for contribution :)

@Trancever Trancever merged commit ee954e8 into callstack:master Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants