feat: ActivityIndicator component #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trancever
suggested changes
Jan 31, 2019
| import * as React from 'react'; | ||
| import { View, StyleSheet } from 'react-native'; | ||
| import { Colors, FAB, withTheme, type Theme } from 'react-native-paper'; | ||
| import { ActivityIndicator } from '../../src'; |
There was a problem hiding this comment.
Can we import it from 'react-native-paper' instead?
| import { withTheme } from '../core/theming'; | ||
| import type { Theme } from '../../types'; | ||
|
|
||
| type Props = {| |
There was a problem hiding this comment.
I think in future we should add type prop for Determinate and Indeterminate states, but it shouldn't be breaking change so we can keep that API as it is.
There was a problem hiding this comment.
You are right but at the moment this component is supposed to be a drop in replacement for the native component. Anyway in the future we could enhance it and just make type as indeterminate as default.
jaulz
force-pushed
the
feat/activity-indicator
branch
from
e39b266
to
b57af16
Compare
jaulz
force-pushed
the
feat/activity-indicator
branch
from
b57af16
to
4408836
Compare
Trancever
approved these changes
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This component serves as a drop-in replacement for the component that is delivered by React Native out of the box. It's design tries to imitate the indeterminate circular progress indicator from the Material guidelines:
https://material.io/design/components/progress-indicators.html#circular-progress-indicators
Test plan
Open examples and see examples of
ActivityIndicator.