Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace 'orderRadius' with 'borderRadius' in Snackbar component #750

Merged
merged 2 commits into from Jan 23, 2019
Merged

fix: replace 'orderRadius' with 'borderRadius' in Snackbar component #750

merged 2 commits into from Jan 23, 2019

Conversation

itsjgf
Copy link
Contributor

@itsjgf itsjgf commented Jan 23, 2019

Motivation

The borderRadius / roundness prop was not working as expected because there was a typo in its name.

Test plan

n/a

@callstack-bot
Copy link

callstack-bot commented Jan 23, 2019 •
edited

Hey @itsjgf, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API.

@Trancever
Copy link
Contributor

Hi @itsjgf Thanks for PR. It looks like bug was introduced with 2b54b06bee105
Could you fix tests (yarn test -u) so we can proceed with merge?

@itsjgf
Copy link
Contributor Author

itsjgf commented Jan 23, 2019

@Trancever done

@Trancever Trancever merged commit 844daf3 into callstack:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trancever Trancever Trancever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@itsjgf @callstack-bot @Trancever