Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep theme compare #6

Closed
souhe opened this issue Feb 13, 2018 · 0 comments
Closed

Deep theme compare #6

souhe opened this issue Feb 13, 2018 · 0 comments

Comments

@souhe
Copy link
Member

souhe commented Feb 13, 2018

We should probably perform a deep equality check here to prevent unnecessary updates: https://github.com/callstack/react-theme-provider/pull/4/files#diff-e51f8bfede732b47a99bd4948620b1e4R38

@souhe souhe mentioned this issue Feb 23, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants