-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] automate branch
and commit hash
CLI options
#207
Comments
Picking this up please. Will it be a good idea to keep these values as default in |
@ShaswatPrabhat Thanks for working on this. I'm not sure I understand your question though. The data flow between the packages should be the same as is now for branch and commit-hash CLI options. The difference should be that when Reassure 'measure' command does not receive either branch or commit-hash option then it tries to get the missing value(s) from Git if possible. |
A good place for checking these values is the very beginning of "run" method in measure.ts in CLI package |
@mdjastrzebski there were a couple of things I wanted to check:
Please let me know if this is what you had thought of |
I've looked more into the |
This is how it is shaping up @mdjastrzebski . Not very happy with the IIFE . Can we not have a simple await based function call immediately in run() method ? Do we need a fork at all |
And an alternative way |
Resolved by #211 |
Is your feature request related to a problem? Please describe.
Automatically detect branch name and commit hash when
reassure
detects that it is run inside a Git repo.Describe the solution you'd like
Basically make current
--branch $(git branch --show-current) --commitHash $(git rev-parse HEAD)
options automatic when user is using Git.Kept the existing CLI options to allow user to override the default values and/or support other source controls systems.
Invoke
git
binary commands using nodechild_process
(?) API to avoid external deps.Describe alternatives you've considered
simple-git
to communicate with GIT repo.Additional context
The text was updated successfully, but these errors were encountered: