-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Validate performance results files input to compare package #208
Comments
@mdjastrzebski I can give this a shot if still open. |
@ShaswatPrabhat go ahead 👍 |
@mdjastrzebski Please find the PR Please let me know if this is along the lines of what you had wanted. Thanks! |
@ShaswatPrabhat thanks for submitting the PRs. Unfortunately I'll need to pause a couple of days on my open source work as I've got cold-like symptoms. I'll review the PRs as soon as I get better. |
@mdjastrzebski please take care. Hope you get well soon. |
Hi, are there any other maintainers in @mdjastrzebski 's absence who can please help review or merge the given commits. Thanks in advance. |
@ShaswatPrabhat I am back and will check your PR today. Thank you for both contribution and panience 🙂 Re other contributors: we also got @thymikee but he is usually even more busy than I am. |
Resolved by #216 |
Is your feature request related to a problem? Please describe.
Currently reading of performance file by
compare
package does not perform any validation, so the CLI could crash with cryptic errors if file is corrupted.Describe the solution you'd like
Use
zod
or other hight quality library to parse/validate contents of the results file. This will require defining schemas for header and entry rows and should be configured to work with TypeScript. In case of error the information about the incorrect line should be displayed.Describe alternatives you've considered
Write validation by hand, but that would be too not worth the tradeoff of additional deps
Additional context
N/A
The text was updated successfully, but these errors were encountered: