-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Not getting a "Significant Changes to Duration" reported #495
Comments
Hi @jkoutavas, I've done a simple repro in our test app by adding your slow down code and it worked correctly. I had to reduce the loop count from 100 000 to 100, as otherwise the test was running too long for my patience: for (let i = 0; i < 100; i++) {
console.log('Delay execution no.' + i);
} ![]() I think you might have something that optimizes your code in a way that removes Could you either post a simplified example so I can re-create your issue (you can use one of our examples as a quick setup). |
@jkoutavas is this issue still valid at your end? |
@mdjastrzebski Hi, thanks for asking. We don't strip console.log() from our app except when built for production: From our
Even with this removed (unnecessary, right?) the issue I reported still remains. Perhaps there's another way to force a slowdown instead of the brute-force "evil" means of doing lots of logging? How do you test for slowdowns? |
@mdjastrzebski ping :-) |
As written before, it works on my end, with event 100
|
Describe the bug
I was expecting the
output.md
file to report a "Significant Changes to Duration" for a<Card>
component I purposefully slowed down after doing a baseline on it.To Reproduce
Steps to reproduce the behavior:
Go to any component under test, and add this evil bit of code...
Then run
yarn reassure
and look at theoutput.md
. In my case, the<Card>
component jumped up dramatically when I added the evil code:...
Where evil was added:
Expected behavior
I would expect Card to be mentioned here (and it isn't)
Additional context
My
Card.perf-test.tsx
:I'm running this with my RN 0.72.10 app with yarn 3.6.4, Reassure 1.0.0-rc.4 (introduces yarn 3.x and 4.x support), and using Jest ^29.7.0 with "@testing-library/react-native ^12.5.0. I'm using all of Reassure's defaults.
The idea behind this "evil" is to see what the report looks like when a component has degraded in performance. All part of evaluating introduction of Reassure to our project.
The text was updated successfully, but these errors were encountered: