Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: automate typechecks on CI #56

Closed
mdjastrzebski opened this issue Jun 23, 2022 · 0 comments · Fixed by #84
Closed

ci: automate typechecks on CI #56

mdjastrzebski opened this issue Jun 23, 2022 · 0 comments · Fixed by #84
Labels
good first issue Good for newcomers help wanted Extra attention is needed improvement

Comments

@mdjastrzebski
Copy link
Member

Describe the improvement
We currently have TypeScript type checks however it is not automatically invoked on CI, hence code is not effectively check with it.

Scope of improvement

  • Add workflow/step on CI
  • Fix any present TS errors

Suggested implementation steps

  1. Fix TS errors locally
  2. Add workflow/workflow step on CI
@mdjastrzebski mdjastrzebski added good first issue Good for newcomers help wanted Extra attention is needed improvement labels Jun 23, 2022
@mdjastrzebski mdjastrzebski changed the title ci: automate typecheks on CI ci: automate typechecks on CI Jun 23, 2022
@mdjastrzebski mdjastrzebski mentioned this issue Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: run tsc & eslint callstack/reassure
1 participant
@mdjastrzebski