Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull subspace in - do not merge until point met #38

Merged
merged 28 commits into from
Aug 9, 2016

Conversation

calum-chamberlain
Copy link
Member

@calum-chamberlain calum-chamberlain commented Jul 4, 2016

@cjhopp has been working on a subspace branch, but it needs some refinement. Before we merge this in, the points below should be met:

  • subspace detector functions;
  • tests written for subspace detector (synthetic data and real data);
  • test different multiplexing technique;
  • optimize inner loop - cython?;
  • tutorial;
  • documentation.
  • a full, efficient looping method for multiple detectors;
  • plotting of the detector object (will only really be useful if not multiplexed);
  • Add network coincidence method.
  • test to confirm detections for multiplexed and non-multiplexed are the same.

- [ ] test for utils.clustering.min_sub_dimension

@calum-chamberlain
Copy link
Member Author

Now operates in an object-oriented sense using the Detector class. Docs and tutorials written, just need to finalise tests.

@calum-chamberlain calum-chamberlain self-assigned this Jul 28, 2016
@calum-chamberlain calum-chamberlain added this to the 0.1.3 milestone Jul 28, 2016
@calum-chamberlain
Copy link
Member Author

Non-multiplexed detection requires lagging, which requires delays to be tracked... Not sure how to do that.

@coveralls
Copy link

coveralls commented Aug 2, 2016

Coverage Status

Coverage increased (+1.8%) to 77.881% when pulling 589afa8 on feature/subspace into 94da62a on develop.

@calum-chamberlain
Copy link
Member Author

Everything is added, merge once green!

@coveralls
Copy link

coveralls commented Aug 3, 2016

Coverage Status

Coverage increased (+2.0%) to 78.078% when pulling d2b3006 on feature/subspace into 94da62a on develop.

@coveralls
Copy link

coveralls commented Aug 3, 2016

Coverage Status

Coverage increased (+2.0%) to 78.078% when pulling ec40725 on feature/subspace into 94da62a on develop.

@calum-chamberlain
Copy link
Member Author

Issue in creation of subspace detector - different on different systems. I think this relates to the alignment of traces, will write an explicit test for this now and check.

@coveralls
Copy link

coveralls commented Aug 9, 2016

Coverage Status

Coverage increased (+2.09%) to 78.198% when pulling b0dd3bb on feature/subspace into 94da62a on develop.

@calum-chamberlain calum-chamberlain merged commit a149d04 into develop Aug 9, 2016
@calum-chamberlain calum-chamberlain deleted the feature/subspace branch August 9, 2016 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants