Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Duplicates when Lights are already in HomeKit #24

Open
sam-brett opened this issue Nov 10, 2022 · 4 comments
Open

Prevent Duplicates when Lights are already in HomeKit #24

sam-brett opened this issue Nov 10, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@sam-brett
Copy link

Is your feature request related to a problem? Please describe:
When lights are already added to HomeKit, using this plug in creates duplicates of the lights. While deleting the existing lights is possible, it also means it creates a lot more work should I decide to stop using HomeBridge

Describe the solution you'd like:
The ability to merge/modify the setting for lights already on the network

Describe alternatives you've considered:
The alternative is to delete all the lights and rely solely on the HomeBridge plugin, which would create a lot of work should I decide not to use HomeBridge in future

Additional context:
I guess as a new HomeBridge user, this might be a niche case. However, its quite a risk if this plug in dies and I have to scan all the codes again.

@sam-brett sam-brett added the enhancement New feature or request label Nov 10, 2022
@StevewHiggs
Copy link

Very much like to add my desire for this feature as well, as the original bulbs age, or newer HomeKit compatible bulbs are brought into the mix, duplicates are an issue. I understand there's an exclude feature, should we be adding each of the new bulbs in there for now? It would be outstanding if the plugin could recognize based on firmware, not to add an entry for the newer bulbs / strips etc.

@calvarium
Copy link
Owner

First up, I have never considered this possibility as the point of the plugin was to save the awkward way of adding each individual bulb, which mostly didn't work anyway.
I've given it some thought and I'm not currently aware of any functionality that can identify devices already added to homekit via homebridge.
If there is this feature please refresh my knowledge and we'll talk more. Otherwise, I am open to other options on how we can block devices.

The plugin offers the function to deactivate "autodiscover" as you can read in the README, so only manually added or already discovered devices are considered. Maybe this variant already helps with your problem.

@StevewHiggs
Copy link

Many thanks for the very very prompt response time!

I was able to add the 3 new bulbs into the exclude section (and made sure my router kept a static IP for them) and my issue was solved.

Also, the ability to operate as a child bridge is awesome! Thanks for providing that option with this plugin. The entire bridge was collapsing when the plug-in couldn’t read a color I suspect from the new z strip. Anyhow I’ve been able to exclude the strip and two newer HomeKit bulbs and all is good.

Your efforts on this project for years has made my dream of taking to my lights a reality. Cheers!

@kaduffey
Copy link

The duplicate issue for me is really bad as I have around 15 LIFX candles, mini's (color and D/D), A19's, and a strip (unused at the moment).
So for example the front and back door pendants take 4 D/D candles each - so when I look at those rooms I see pendant1-4 and 'front pendant' group that also has four candles. Two sconces in the front hall with two D/D minis do the same. So the clutter is getting quite bad.

If I remove this plugin will it cleanup Homekit and remove dups? Then I can try again with excludes?

Perhaps discover/scan first and look for existing lights by homekit code or MAC ID, then auto exclude those from being added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants