Stable Picture-In-Picture mode #67

msp-ampcome · 2021-12-30T10:14:29Z

Hey, Hope you are doing well. We are trying to use the PIP mode. But once we enter the pip mode, we can interact with the app without any issues but video and audio become very unstable/glitchy. is there any way to stabilize this issue. Because in the jitsi meet app, the pip mode is working fine. Please let us know if there is any solution. Thank you for creating this plugin.

jefaokpta · 2021-12-30T14:36:38Z

Have you tested the pip on Android or IOS? If it's on Android, did you need to change something in the native code?

msp-ampcome · 2021-12-31T03:55:37Z

It is on android. I have to change the AndroidManifest in the plugin to enable PIP. but once enabled, going in and out of PIP is very jarring experience. but it working on jitsi meet app and flutter plugin.

jefaokpta · 2022-01-03T15:13:28Z

It is on android. I have to change the AndroidManifest in the plugin to enable PIP. but once enabled, going in and out of PIP is very jarring experience. but it working on jitsi meet app and flutter plugin.

I had the same experience, on native code and in flutter works pretty well. Even with this issue I rather Ionic than others. It's more simple.

calvinckho · 2022-01-03T15:26:12Z

I intentionally disabled PIP on the plugin for this reason. I will investigate again and see if there is any solution.

calvinckho · 2022-01-04T02:26:19Z

@jefaokpta @msp-ampcome According to the Jitsi mobile SDK documentation:

Jitsi Meet SDK does not currently implement native Picture-in-Picture on iOS. If desired, apps need to implement non-native Picture-in-Picture themselves and resize JitsiMeetView.

I currently do not have time to work on this, but you are welcome to try and add non-native support for PIP in iOS and submit a PR.

As for PIP support on Android, I have done some work and seem to be able to get it to work. Try to install 2.1.2-beta.0 and deploy it on Android to test it.

msp-ampcome · 2022-01-04T03:16:40Z

@calvinckho Hey thanks for the quick update, I installed the beta version and tested it. Now PIP mode is working properly, Audio/Video is working as expected. But If i disconnect the call, the app is crashing, regardless of whether i entered PIP mode or not. This is the error I am getting and attached the screen record for your reference
`
E/JitsiMeetSDK: JitsiMeetUncaughtExceptionHandler FATAL ERROR
java.lang.RuntimeException: Unable to stop activity {com.kr4all.doctorapp/com.capacitor.jitsi.plugin.JitsiActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void org.jitsi.meet.sdk.JitsiMeetView.dispose()' on a null object reference
at android.app.ActivityThread.callActivityOnStop(ActivityThread.java:4956)
at android.app.ActivityThread.performStopActivityInner(ActivityThread.java:4927)
at android.app.ActivityThread.handleStopActivity(ActivityThread.java:5001)
at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:233)
at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:201)
at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:173)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2116)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:236)
at android.app.ActivityThread.main(ActivityThread.java:7904)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:656)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:967)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void org.jitsi.meet.sdk.JitsiMeetView.dispose()' on a null object reference
at com.capacitor.jitsi.plugin.JitsiActivity.onStop(JitsiActivity.java:162)
at android.app.Instrumentation.callActivityOnStop(Instrumentation.java:1477)
at android.app.Activity.performStop(Activity.java:8358)
at android.app.ActivityThread.callActivityOnStop(ActivityThread.java:4948)
at android.app.ActivityThread.performStopActivityInner(ActivityThread.java:4927)
at android.app.ActivityThread.handleStopActivity(ActivityThread.java:5001)
at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:233)
at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:201)
at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:173)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2116)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:236)
at android.app.ActivityThread.main(ActivityThread.java:7904)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:656)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:967)

java.lang.RuntimeException: Unable to stop activity {com.kr4all.doctorapp/com.capacitor.jitsi.plugin.JitsiActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void org.jitsi.meet.sdk.JitsiMeetView.dispose()' on a null object reference
    at android.app.ActivityThread.callActivityOnStop(ActivityThread.java:4956)
    at android.app.ActivityThread.performStopActivityInner(ActivityThread.java:4927)
    at android.app.ActivityThread.handleStopActivity(ActivityThread.java:5001)
    at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:233)
    at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:201)
    at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:173)
    at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2116)
    at android.os.Handler.dispatchMessage(Handler.java:106)
    at android.os.Looper.loop(Looper.java:236)
    at android.app.ActivityThread.main(ActivityThread.java:7904)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:656)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:967)
 Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void org.jitsi.meet.sdk.JitsiMeetView.dispose()' on a null object reference
    at com.capacitor.jitsi.plugin.JitsiActivity.onStop(JitsiActivity.java:162)
    at android.app.Instrumentation.callActivityOnStop(Instrumentation.java:1477)
    at android.app.Activity.performStop(Activity.java:8358)
    at android.app.ActivityThread.callActivityOnStop(ActivityThread.java:4948)
    at android.app.ActivityThread.performStopActivityInner(ActivityThread.java:4927) 
    at android.app.ActivityThread.handleStopActivity(ActivityThread.java:5001) 
    at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:233) 
    at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:201) 
    at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:173) 
    at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97) 
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2116) 
    at android.os.Handler.dispatchMessage(Handler.java:106) 
    at android.os.Looper.loop(Looper.java:236) 
    at android.app.ActivityThread.main(ActivityThread.java:7904) 
    at java.lang.reflect.Method.invoke(Native Method) 
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:656) 
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:967)

I/JitsiMeetSDK: [features/base/connection] No connection found while disconnecting.
[FeatureFlags] Source name signaling: false
D/JitsiMeetSDK: [modules/connectivity/NetworkInfo.js] updateNetworkInfo { isOnline: true }
I/JitsiMeetSDK: [features/analytics] Initialized 1 analytics handlers
I/JitsiMeetSDK: [features/base/media] Start muted:
D/JitsiMeetSDK: ExternalAPI Sending event: VIDEO_MUTED_CHANGED with data: { NativeMap: {"muted":0} }
I/JitsiMeetSDK: [features/base/media] Start audio only set to false`

https://drive.google.com/file/d/1rS0z_SlgpPvXN4NHHrNa_DVvn6Pm5OCQ/view?usp=sharing

calvinckho · 2022-01-04T03:35:06Z

can you try 2.1.2-beta.1? I fixed a bug which caused the crash.

msp-ampcome · 2022-01-04T03:37:54Z

Will try and let you know

msp-ampcome · 2022-01-04T03:48:14Z

@calvinckho Yeah, now the crash is fixed. Thank you so much. We really appreciate your quick response and your hard work. I tested it on Android 11. We will test it on more devices and let you know the results.

msp-ampcome · 2022-01-04T07:05:53Z

@calvinckho sometimes the status bar is showing up on PIP mode. like this https://ibb.co/GCK0ss8

calvinckho · 2022-01-04T22:32:33Z

@msp-ampcome yes I also noticed it on my test app PIP window. The header bar would stay for a few seconds and then disappear. Have you noticed the same UI behavior in the official Jitsi app?

msp-ampcome · 2022-01-05T02:29:18Z

@calvinckho In the official app, the header bar is not showing. Maybe we have to remove the title bar ourselves like shown here.
https://stackoverflow.com/questions/36236181/how-to-remove-title-bar-from-the-android-activity/36236222

calvinckho · 2022-01-06T00:46:11Z

@msp-ampcome Thanks for your research. It was helpful. I disabled the header bar in the plugin's AndroidMannifest.xml file. Please try 2.1.2-beta.2 in your test app.

msp-ampcome · 2022-01-08T04:33:24Z

@calvinckho Thanks for the update, We tested it, now the header bar is not coming. But we found an another bug. if the user closed the PIP window with the close button. the call is not disconnected on jitsi. if you rejoin the call. you can see 3 participants. You can see your name twice. one is current session, another one is the previous dead version. This issue is not coming, if we disconnect from the meeting properly via the reject call button on the expanded jitsi view.

calvinckho · 2022-01-09T17:32:01Z

Ok let me check on this issue.

calvinckho · 2022-01-29T17:22:37Z

@calvinckho Thanks for the update, We tested it, now the header bar is not coming. But we found an another bug. if the user closed the PIP window with the close button. the call is not disconnected on jitsi. if you rejoin the call. you can see 3 participants. You can see your name twice. one is current session, another one is the previous dead version. This issue is not coming, if we disconnect from the meeting properly via the reject call button on the expanded jitsi view.

OK. also want to check if this issue is still experienced when you use 2.1.2-beta.2 in Android?

calvinckho · 2022-02-05T02:05:24Z

@calvinckho Thanks for the update, We tested it, now the header bar is not coming. But we found an another bug. if the user closed the PIP window with the close button. the call is not disconnected on jitsi. if you rejoin the call. you can see 3 participants. You can see your name twice. one is current session, another one is the previous dead version. This issue is not coming, if we disconnect from the meeting properly via the reject call button on the expanded jitsi view.

OK. also want to check if this issue is still experienced when you use 2.1.2-beta.2 in Android?

I have tried to reproduce this bug. It tried to open and close the PIP window about 15 times. Out of the 15 times, only 1 time did it fail to leave the call. The other 14 times it was able to leave the call.

Perhaps it is a race condition? But as I was not able to reproduce the issue, it is very difficult to debug it. Also, I cannot merge it with the main branch until this issue is resolved.

calvinckho · 2022-02-09T03:21:32Z

2.1.2 is released with the PiP mode disabled on Android because of the instability reported above. For future testing purposes, you can install 2.1.2+ and do the follow to enable PIP mode for Android:

In Capacitor-Jitsi-Meet's AndroidManifest.xml, set android:supportsPictureInPicture="true"
In JitsiActivity.java, uncomment the onStop() handler code (line 170 - 179).

Things to test and report:

Please let me know if you experience any issue with closing the PIP window manually.
The issue has been reported, but it was difficult to reproduce as it does not happen consistently. It can be due to race condition or other unknown causes.

calvinckho · 2022-03-05T07:32:22Z

@calvinckho Thanks for the update, We tested it, now the header bar is not coming. But we found an another bug. if the user closed the PIP window with the close button. the call is not disconnected on jitsi. if you rejoin the call. you can see 3 participants. You can see your name twice. one is current session, another one is the previous dead version. This issue is not coming, if we disconnect from the meeting properly via the reject call button on the expanded jitsi view.

PIP in Android is now fully supported in the 2.2.0 release. The bug mentioned above should be fixed. To enable PIP in Android:

i. In the plugin's AndroidManifest.xml, set supportsPictureInPicture to true.

android:supportsPictureInPicture="true"

ii. Set the featureFlags param 'pip.enabled' to true

featureFlags: { 'pip.enabled': true }

For iOS PIP implementation, as the Jitsi SDK doesn't support native PIP yet, for those who need it in their iOS deployment, I offer consultation service to help you implement it in a non-native way. See this video for a demo:

RPReplay_Final1646465120.MP4

Feel free to DM me for more info.

calvinckho closed this as completed Feb 9, 2022

Repository owner deleted a comment from msp-ampcome Feb 14, 2022

This was referenced Mar 5, 2022

Picture in Picture not working #20

Closed

JitsiMeetSDK: [features/mobile/pip] Error entering PiP mode: Error: enterPictureInPictureMode: Current activity does not support picture-in-picture. #59

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stable Picture-In-Picture mode #67

Stable Picture-In-Picture mode #67

msp-ampcome commented Dec 30, 2021

jefaokpta commented Dec 30, 2021

msp-ampcome commented Dec 31, 2021

jefaokpta commented Jan 3, 2022

calvinckho commented Jan 3, 2022

calvinckho commented Jan 4, 2022

msp-ampcome commented Jan 4, 2022 •

edited

Loading

calvinckho commented Jan 4, 2022

msp-ampcome commented Jan 4, 2022

msp-ampcome commented Jan 4, 2022

msp-ampcome commented Jan 4, 2022

calvinckho commented Jan 4, 2022

msp-ampcome commented Jan 5, 2022 •

edited

Loading

calvinckho commented Jan 6, 2022

msp-ampcome commented Jan 8, 2022

calvinckho commented Jan 9, 2022

calvinckho commented Jan 29, 2022

calvinckho commented Feb 5, 2022

calvinckho commented Feb 9, 2022 •

edited

Loading

calvinckho commented Mar 5, 2022 •

edited

Loading

Stable Picture-In-Picture mode #67

Stable Picture-In-Picture mode #67

Comments

msp-ampcome commented Dec 30, 2021

jefaokpta commented Dec 30, 2021

msp-ampcome commented Dec 31, 2021

jefaokpta commented Jan 3, 2022

calvinckho commented Jan 3, 2022

calvinckho commented Jan 4, 2022

msp-ampcome commented Jan 4, 2022 • edited Loading

calvinckho commented Jan 4, 2022

msp-ampcome commented Jan 4, 2022

msp-ampcome commented Jan 4, 2022

msp-ampcome commented Jan 4, 2022

calvinckho commented Jan 4, 2022

msp-ampcome commented Jan 5, 2022 • edited Loading

calvinckho commented Jan 6, 2022

msp-ampcome commented Jan 8, 2022

calvinckho commented Jan 9, 2022

calvinckho commented Jan 29, 2022

calvinckho commented Feb 5, 2022

calvinckho commented Feb 9, 2022 • edited Loading

calvinckho commented Mar 5, 2022 • edited Loading

msp-ampcome commented Jan 4, 2022 •

edited

Loading

msp-ampcome commented Jan 5, 2022 •

edited

Loading

calvinckho commented Feb 9, 2022 •

edited

Loading

calvinckho commented Mar 5, 2022 •

edited

Loading