Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WaterSchedules as a separate resource and allow for multiple per Zone #22

Closed
calvinmclean opened this issue Oct 3, 2022 · 0 comments · Fixed by #99
Closed
Labels
enhancement New feature or request server Related to the Go garden-app code

Comments

@calvinmclean
Copy link
Owner

calvinmclean commented Oct 3, 2022

Description

It would be nice to be able to define more complex WaterSchedules for a Zone. This would allow for watering a Zone multiple times in one day (such as morning/evening, mid-afternoon top-off, or a multiple short soaks for even, deep watering). A complex configuration like this might be annoying to work with as a JSON object nested under a Zone. Also, after putting careful consideration into the WaterSchedule, you might want to use it in multiple Zones without reconfiguring.

Requirements

  • Manage WaterSchedules as separate API resources, independent of Gardens or Zones
  • Reference by ID in a Zone
  • WaterSchedules run independent of Zones as their own scheduled "thing" and it will check for any eligible Zones when it executes
    • This results in fewer scheduled Jobs needing to be managed if I have multiple Zones using the same schedule
    • Manual delaying of watering can go back to the old way of keeping a counter on a Zone of the number of skips, or more likely a timestamp saying the next time it can be watered
    • Possible annoying thing or issue with this implementation is that next_watering_time and weather_data is now tied to the WaterSchedule + Zone. I will implement the response on the WaterSchedule API and then the ZoneResponse can use the same methods and compensate for any configured skips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request server Related to the Go garden-app code
Projects
None yet
1 participant