added dry-run flag to create core_instance kubernetes #346

jasmingacic · 2023-02-23T13:02:50Z

Summary of this proposal

Fixes https://github.com/calyptia/cloud/issues/767

now by running:

# calyptia create core_instance kubernetes --dry-run
[Debug] [Error] could not retrive your stored url: data not found
The default url https://cloud-api.calyptia.com will be used instead

---
kind: Secret
apiVersion: v1
metadata:
  name: calyptia-trusted-ink-155e-default-secret
  creationTimestamp: null
  labels:
    app.kubernetes.io/created-by: calyptia-cli
    app.kubernetes.io/managed-by: calyptia-cli
    app.kubernetes.io/part-of: calyptia
...

users can get k8s yaml file with k8s resources the output can be piped like

# calyptia create core_instance kubernetes --dry-run | kubectl apply -f -
[Debug] [Error] could not retrive your stored url: data not found
The default url https://cloud-api.calyptia.com/ will be used instead

secret/calyptia-clean-darkhawk-2b22-default-secret created
clusterrole.rbac.authorization.k8s.io/calyptia-clean-darkhawk-2b22-default-cluster-role created
serviceaccount/calyptia-clean-darkhawk-2b22-default-service-account created
clusterrolebinding.rbac.authorization.k8s.io/calyptia-clean-darkhawk-2b22-default-cluster-role-binding created
deployment.apps/calyptia-clean-darkhawk-2b22-default-deployment created

Signed-off-by: jasmingacic <jasmin@calyptia.com>

jasmingacic · 2023-02-23T13:03:28Z

k8s/client.go

 		ObjectMeta: metadata,
 		Data: map[string][]byte{
 			metadata.Name: agg.PrivateRSAKey,
 		},
-	}, metav1.CreateOptions{})
+	}
+	req.TypeMeta = metav1.TypeMeta{


These values need to be populated so the yaml output contains valid values.

jasmingacic · 2023-02-23T13:04:46Z

cmd/coreinstance/create_core_instance_k8s.go

@@ -166,3 +182,14 @@ func newCmdCreateCoreInstanceOnK8s(config *cfg.Config, testClientSet kubernetes.

 	return cmd
 }
+
+// GetK8sYaml strips empty properties which would typically be marshalled with yaml.Marshal
+func GetK8sYaml(req interface{}) {


If return object from k8s is marshalled into Yaml all empty fields will be marshalled as well. Only with JSON that doesn't happen.
So this is a clumsy workaround that.

patrick-stephens · 2023-02-23T14:50:07Z

Does this only work for that specific command? I can see it being useful for any interacting directly with K8S but we probably need to consider the AWS/GCP command to ensure it fails there for now.

We don't want a user thinking they'll get a dry run but actually stuff is applied.

jasmingacic · 2023-02-23T14:51:41Z

Dry run is only for Kubernetes I didn't touch GCP or AWS. I don't think we can make it like this for GCP and AWS. We could maybe print out what the command will do but it won't be something we can pipe into kubectl.
Perhaps making curl output could be useful?

nicolasparada · 2023-02-24T16:27:19Z

cmd/coreinstance/create_core_instance_k8s.go

@@ -166,3 +182,14 @@ func newCmdCreateCoreInstanceOnK8s(config *cfg.Config, testClientSet kubernetes.

 	return cmd
 }
+
+// GetK8sYaml strips empty properties which would typically be marshalled with yaml.Marshal
+func GetK8sYaml(req interface{}) {


Suggested change

func GetK8sYaml(req interface{}) {

func printK8sYaml(req any) {

"Get" denotes getting a value, but this function doesn't return anything. Also, it's not reused outside so why export it.

nicolasparada · 2023-02-24T16:28:12Z

cmd/coreinstance/create_core_instance_k8s.go

+	input := strings.NewReader(string(out))
+	var output strings.Builder
+	if err := json2yaml.Convert(&output, input); err != nil {
+		log.Fatalln(err)


I'm not fan of panic... Maybe you can log.Print and return instead. Panic will give you a stack trace.

nicolasparada

Left some comments.

Signed-off-by: jasmingacic <jasmin@calyptia.com>

nicolasparada · 2023-02-24T16:31:39Z

cmd/coreinstance/create_core_instance_k8s.go

+	input := strings.NewReader(string(out))
+	var output strings.Builder
+	if err := json2yaml.Convert(&output, input); err != nil {
+		log.Println("failed to convert JSON to YAML:", err)


Suggested change

log.Println("failed to convert JSON to YAML:", err)

log.Println("failed to convert JSON to YAML:", err)

return

nicolasparada

Missing a return.

Signed-off-by: jasmingacic <jasmin@calyptia.com>

sonarcloud · 2023-02-24T16:33:34Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

patrick-stephens · 2023-02-24T16:34:46Z

LGTM - I'll merge once CI is green

* formatters and completer * added pkg/config package Signed-off-by: jasmingacic <jasmin@calyptia.com> * minor cleanup * part of completer done * another completer phase * another completer phase 3 * removed PKG directory Signed-off-by: jasmingacic <jasmin@calyptia.com> * moved commands to model directories changed goreleaser, added Makefile and various changes Signed-off-by: jasmingacic <jasmin@calyptia.com> * added install.sh - it fetches CLI binaries from GH Signed-off-by: jasmingacic <jasmin@calyptia.com> * build fix Signed-off-by: jasmingacic <jasmin@calyptia.com> * minor tweak Signed-off-by: jasmingacic <jasmin@calyptia.com> * Dockerfile fix Signed-off-by: jasmingacic <jasmin.gacic@gmail.com> * fixed install.sh Signed-off-by: jasmingacic <jasmin.gacic@gmail.com> * check config fix Signed-off-by: jasmingacic <jasmin.gacic@gmail.com> * shellcheck fixes for install.sh Signed-off-by: jasmingacic <jasmin@calyptia.com> * added slice package Signed-off-by: jasmingacic <jasmin@calyptia.com> * renamed UniqueSlice to Unique Signed-off-by: jasmingacic <jasmin@calyptia.com> * moved formatting functions to formatters package Signed-off-by: jasmingacic <jasmin@calyptia.com> * added confirm package Signed-off-by: jasmingacic <jasmin@calyptia.com> * added package metric Signed-off-by: jasmingacic <jasmin@calyptia.com> * rename ReadConfirm to Read Signed-off-by: jasmingacic <jasmin@calyptia.com> * Added calyptia version subcommand Signed-off-by: jasmingacic <jasmin@calyptia.com> * switched from fmt to cmd Signed-off-by: jasmingacic <jasmin@calyptia.com> * Added short description * removed error silencing Signed-off-by: jasmingacic <jasmin@calyptia.com> * typo fix Signed-off-by: jasmingacic <jasmin@calyptia.com> * typo fix and default BaseURL Signed-off-by: jasmingacic <jasmin@calyptia.com> * error handling for token retrieval Signed-off-by: jasmingacic <jasmin@calyptia.com> * adding pod namespace as environment variable in the container (#349) * adding pod namespace as environment variable in the container Signed-off-by: jasmingacic <jasmin@calyptia.com> * added deployment name to the container Signed-off-by: jasmingacic <jasmin@calyptia.com> --------- Signed-off-by: jasmingacic <jasmin@calyptia.com> * added dry-run flag to create core_instance kubernetes (#346) * added dry-run flag to create core_instance kubernetes Signed-off-by: jasmingacic <jasmin@calyptia.com> * cmd: check base url from localdata error * goimports * remove unused coreInstanceKeys func * re-sort dangling import groups --------- Signed-off-by: jasmingacic <jasmin@calyptia.com> Signed-off-by: jasmingacic <jasmin.gacic@gmail.com> Co-authored-by: Nicolás Parada <nicolas@calyptia.com>

added dry-run flag to create core_instance kubernetes

e89280e

Signed-off-by: jasmingacic <jasmin@calyptia.com>

jasmingacic requested review from pwhelan, gabrielbussolo, patrick-stephens and nicolasparada February 23, 2023 13:02

jasmingacic commented Feb 23, 2023

View reviewed changes

nicolasparada reviewed Feb 24, 2023

View reviewed changes

nicolasparada suggested changes Feb 24, 2023

View reviewed changes

minor fix

deeec1f

Signed-off-by: jasmingacic <jasmin@calyptia.com>

jasmingacic requested a review from nicolasparada February 24, 2023 16:30

nicolasparada reviewed Feb 24, 2023

View reviewed changes

nicolasparada suggested changes Feb 24, 2023

View reviewed changes

jasmingacic added 2 commits February 24, 2023 16:32

fix conflicts

8d476cd

Signed-off-by: jasmingacic <jasmin@calyptia.com>

Added missing return

0800d51

jasmingacic requested a review from nicolasparada February 24, 2023 16:33

nicolasparada approved these changes Feb 24, 2023

View reviewed changes

patrick-stephens approved these changes Feb 24, 2023

View reviewed changes

patrick-stephens merged commit e63169a into completion_refactor Feb 24, 2023

patrick-stephens deleted the cli_dry-run_for_k8s branch February 24, 2023 16:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added dry-run flag to create core_instance kubernetes #346

added dry-run flag to create core_instance kubernetes #346

jasmingacic commented Feb 23, 2023

jasmingacic Feb 23, 2023

jasmingacic Feb 23, 2023

patrick-stephens commented Feb 23, 2023

jasmingacic commented Feb 23, 2023 •

edited

Loading

nicolasparada Feb 24, 2023

jasmingacic Feb 24, 2023

nicolasparada Feb 24, 2023

jasmingacic Feb 24, 2023

nicolasparada left a comment

nicolasparada Feb 24, 2023

nicolasparada left a comment

sonarcloud bot commented Feb 24, 2023

patrick-stephens commented Feb 24, 2023

	func GetK8sYaml(req interface{}) {
	func printK8sYaml(req any) {

	log.Println("failed to convert JSON to YAML:", err)
	log.Println("failed to convert JSON to YAML:", err)
	return

added dry-run flag to create core_instance kubernetes #346

added dry-run flag to create core_instance kubernetes #346

Conversation

jasmingacic commented Feb 23, 2023

Summary of this proposal

jasmingacic Feb 23, 2023

Choose a reason for hiding this comment

jasmingacic Feb 23, 2023

Choose a reason for hiding this comment

patrick-stephens commented Feb 23, 2023

jasmingacic commented Feb 23, 2023 • edited Loading

nicolasparada Feb 24, 2023

Choose a reason for hiding this comment

jasmingacic Feb 24, 2023

Choose a reason for hiding this comment

nicolasparada Feb 24, 2023

Choose a reason for hiding this comment

jasmingacic Feb 24, 2023

Choose a reason for hiding this comment

nicolasparada left a comment

Choose a reason for hiding this comment

nicolasparada Feb 24, 2023

Choose a reason for hiding this comment

nicolasparada left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Feb 24, 2023

patrick-stephens commented Feb 24, 2023

jasmingacic commented Feb 23, 2023 •

edited

Loading