Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link in Commonalities v0.3.0 Design Guidelines #167

Closed
hdamker opened this issue Mar 13, 2024 · 4 comments
Closed

Broken link in Commonalities v0.3.0 Design Guidelines #167

hdamker opened this issue Mar 13, 2024 · 4 comments
Labels
correction correction in documentation

Comments

@hdamker
Copy link
Collaborator

hdamker commented Mar 13, 2024

Problem description

The link within line 874 of the Design Guidelines is broken. It points to https://github.com/camaraproject/IdentityAndConsentManagement/tree/main/documentation/CAMARA-AuthN-AuthZ-Concept.md in main branch of ICM but was there deleted after release 0.1 of IC&M.

Expected behavior

Within release v0.3.x of Commonalities the link should point either to https://github.com/camaraproject/IdentityAndConsentManagement/blob/release-0.1.0/documentation/CAMARA-API-access-and-user-consent.md or https://github.com/camaraproject/IdentityAndConsentManagement/blob/release-0.1.0/documentation/CAMARA-AuthN-AuthZ-Concept.md

It need to be corrected also in the main branch (v0.1 is still the current release of IC&M)

Alternative solution

The proposed solution approach in camaraproject/IdentityAndConsentManagement#139 would also address the issue here in Commonalities.

Additional context

https://github.com/camaraproject/IdentityAndConsentManagement/blob/release-0.1.0/documentation/CAMARA-AuthN-AuthZ-Concept.md has the same issue ... it is also pointing to the deleted file https://github.com/camaraproject/IdentityAndConsentManagement/tree/main/documentation/CAMARA-AuthN-AuthZ-Concept.md in mainof ICM.

@rartych
Copy link
Collaborator

rartych commented Apr 26, 2024

The issue will be resolved with the alternative solution described in camaraproject/IdentityAndConsentManagement#139

@hdamker
Copy link
Collaborator Author

hdamker commented May 2, 2024

Corrected for v0.3.0 with camaraproject/IdentityAndConsentManagement#147. Please ensure that the next release won't contain links to unreleased versions of documents (aka "main" branch).

@hdamker
Copy link
Collaborator Author

hdamker commented May 15, 2024

@rartych this issue can be closed, fixed with camaraproject/IdentityAndConsentManagement#147

@rartych
Copy link
Collaborator

rartych commented May 17, 2024

Closing as indicated above.

@rartych rartych closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction correction in documentation
Projects
None yet
Development

No branches or pull requests

2 participants