Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SUBSCRIPTION_DELETED as a terminationReason [event-subscription-template.yaml] #237

Closed
maxl2287 opened this issue Jun 17, 2024 · 1 comment · Fixed by #238
Closed
Labels
enhancement New feature or request

Comments

@maxl2287
Copy link
Contributor

maxl2287 commented Jun 17, 2024

Problem description
As of now we have the current valid values of terminationReason:

    TerminationReason:
      type: string
      description: |
        - NETWORK_TERMINATED - API server stopped sending notification
        - SUBSCRIPTION_EXPIRED - Subscription expire time (optionally set by the requester) has been reached
        - MAX_EVENTS_REACHED - Maximum number of events (optionally set by the requester) has been reached
        - ACCESS_TOKEN_EXPIRED - Access Token sinkCredential (optionally set by the requester) expiration time has been reached
      enum:
        - MAX_EVENTS_REACHED
        - NETWORK_TERMINATED
        - SUBSCRIPTION_EXPIRED
        - ACCESS_TOKEN_EXPIRED

But we do not have a termination-reason when the Subscription was deleted by the User.

Possible evolution
Add SUBSCRIPTION_DELETED as a new terminationReason.

Related Issues

@maxl2287 maxl2287 added the enhancement New feature or request label Jun 17, 2024
@maxl2287 maxl2287 changed the title Adding SUBSCRIPTION_DELETED as a TerminationReason [event-subscription-template.yaml] Adding SUBSCRIPTION_DELETED as a terminationReason [event-subscription-template.yaml] Jun 17, 2024
@PedroDiez
Copy link
Collaborator

To me is fine, when discussing the model we initiallly decided to not explicitly add it. If it is consensus, no problem on adding it from our side. cc @bigludo7 , @shilpa-padgaonkar for them to be aware of this topic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants