Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed renaming of device identifier API #40

Closed
eric-murray opened this issue Dec 1, 2023 · 1 comment · Fixed by #45
Closed

Proposed renaming of device identifier API #40

eric-murray opened this issue Dec 1, 2023 · 1 comment · Fixed by #45

Comments

@eric-murray
Copy link
Collaborator

Problem description
Current name of the device identifier API in the basepath is dvi. However, as an additional API "IMEI Fraud" has been included in the sub-project ,it is no longer appropriate to name the device identifier API after the sub-project.

Expected behaviour
API name in basepath should closer reflect the documentation name. As hyphens are allowed in the basepath name, it is proposed to change this to device-identifier.

Alternative solution
None proposed

Additional context
This new name follows the convention adopted by many other APIs
@sachinvodafone
Copy link

Hi @eric-murray , It looks fine to me. Thanks

@eric-murray eric-murray mentioned this issue Jan 9, 2024
Merged
@Kevsy Kevsy closed this as completed in #45 Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update CAMARA Device Identifier API.yaml eric-murray/DeviceIdentifier
2 participants
@eric-murray @sachinvodafone