Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend QoS Profile queries to list profiles based on specific users or devices #166

Open
RandyLevensalor opened this issue Jun 16, 2023 · 5 comments · May be fixed by #318
Open

Extend QoS Profile queries to list profiles based on specific users or devices #166

RandyLevensalor opened this issue Jun 16, 2023 · 5 comments · May be fixed by #318
Assignees
Labels
enhancement New feature or request QoD v0.11.0 Within scope for v0.11.0

Comments

@RandyLevensalor
Copy link
Collaborator

Problem description
Some QoS profiles may not be available to every customer. This can be due to their current plan, capabilities/capacity of the local network, device features or other attributes. So only a set of available profiles should be returned.

Possible evolution

Alternative solution

Additional context

@hdamker
Copy link
Collaborator

hdamker commented Dec 14, 2023

MOM-2023-12-01:

  • Potential candidate for v0.11.0
  • Adding another endpoint with device parameter in body of POST operation could be one option

@hdamker hdamker added QoD and removed QoD-backlog labels Dec 14, 2023
@hdamker hdamker added the v0.11.0 Within scope for v0.11.0 label Feb 11, 2024
@emil-cheung
Copy link
Collaborator

emil-cheung commented Feb 23, 2024

Problem description Some QoS profiles may not be available to every customer. This can be due to their current plan, capabilities/capacity of the local network, device features or other attributes. So only a set of available profiles should be returned.

Possible evolution

Alternative solution

Additional context

The discovery endpoint filters QoS profiles based on target user's mobile subscription which makes some sense.
However, filtering QoS profiles bases on network capacity is a bit tricky. As network capacity is so dynamic, usually the Policy node in a network shall consider.

I would suggest that we only scope the mobile subscription aspect at least at this stage.

@jlurien
Copy link
Collaborator

jlurien commented Feb 23, 2024

Once we proceed with the agreed split (#265), we can discuss further enhancements.
I see two approaches:

  1. If we consume that endpoint with client credentials, we'd need a filter to be passed. If we have to pass personal information as phone numbers, we probably need to change to a POST method.
  2. With a three-legged access token we can rely on the info linked to the access token, to let the implementation adapt the response to it.

@RandyLevensalor
Copy link
Collaborator Author

This is looking similar to the query in issue #101 and I think that it could be follow a similar pattern using both the three-legged access token and the device schema in the request.

@jlurien
Copy link
Collaborator

jlurien commented May 31, 2024

Yes, it's quite the same situation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request QoD v0.11.0 Within scope for v0.11.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants